NOMERGE: Add bare-minimum Session API from proposal draft #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrrobin
reviewed
Sep 30, 2022
mpp/shmem-def.h.in
Outdated
| #define SHMEM_SESSION_OP_AMO (1l<<3) | ||
| #define SHMEM_SESSION_OP_AMO_FETCH (1l<<4) | ||
| #define SHMEM_SESSION_CHAIN (1l<<5) | ||
| #define SHMEM_SESSION_UNIFORM_AMO (1l<<6) |
There was a problem hiding this comment.
Is there a reason we are not using _OP_ for the last two? No issue with the naming, I just want to understand if there is a reason.
wrrobin
reviewed
Sep 30, 2022
| /* Session Routines */ | ||
| SHMEM_FUNCTION_ATTRIBUTES void SHPRE()shmem_session_start(long options, shmem_ctx_t ctx); | ||
| SHMEM_FUNCTION_ATTRIBUTES void SHPRE()shmem_session_stop(shmem_ctx_t ctx); | ||
|
|
There was a problem hiding this comment.
Might have to move them to shmemx later.
davidozog
force-pushed
the
wip/sessions
branch
2 times, most recently
from
eba3fbd to
781d881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example of bare-minimum support for the OpenSHMEM Sessions proposal (openshmem-org/specification#493). It's a work-in-progress, and we might prefer to put it in
shmemx, depending on committee feedback and the spec release timeline.