Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download certs from security plugin instead of storing local copy #1880

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Download certs from security plugin instead of storing local copy #1880

wants to merge 25 commits into from
+98 −106

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Nov 5, 2024

Description

Download certs from security repo instead of having a local copy in this repo.

Testing out this same pattern that the sql plugin uses to reduce copies of the demo certs across plugin repos.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks cwperks changed the title Down certs from security plugin instead of storing local copy Download certs from security plugin instead of storing local copy Nov 5, 2024
@cwperks
Set target compatibility to 21 on main
68da387 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Remove commented out code
4987472 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Revert targetCompatibility change
27e0008 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Set kotlinTarget to 17
43bded9 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Set targetCompatibility to 17
6a55c93 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Set java target to 21
a075e1d 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Change target to 21
42f77b3 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Upgrade kotlin.version
eeec142 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Update bwc base version
5d1d829 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Upgrade gradle and remove 404 links
5cf2e22 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Force resolve
83edcbc 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Add perm
2974e63 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Surround in doPrivileged
f942145 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Remove unused import
bc3c97c 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Move env higher level
1f838c7 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Add env to container
4685944 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Add on container level
6f3167a 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Use v3
e7eff2e 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Merge branch 'main' into download-certs-from-security
e1acbf8
@cwperks
Set max-redirects
ce9ebdc 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Update syntax
43ae747 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Update to v4
b739ebd 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Route to login page
309808a 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks cwperks marked this pull request as ready for review December 5, 2024 16:44
@cwperks cwperks requested a review from ps48 as a code owner December 5, 2024 16:44
@cwperks cwperks mentioned this pull request Dec 5, 2024
Open
5 tasks
YANG-DB
YANG-DB approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@YANG-DB YANG-DB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cwperks !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YANG-DB YANG-DB YANG-DB approved these changes

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vamsi-amazon vamsi-amazon Awaiting requested review from vamsi-amazon vamsi-amazon is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
ci maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwperks @YANG-DB