Fix deprecated GitHub upload artifact action version #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YANGDB <[email protected]>
YANG-DB
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
Comment on lines
25
to
26
| env: | ||
| ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true |
There was a problem hiding this comment.
This section can be entirely removed as it is already deprecated by github.
| @@ -58,7 +61,7 @@ jobs: | |||
| cp -r ./build/distributions/*.zip opensearch-observability-builds/ | |||
|
|
|||
| - name: Upload Artifacts | |||
| uses: actions/upload-artifact@v1 | |||
| uses: actions/upload-artifact@v3-node20 | |||
There was a problem hiding this comment.
Use v4, as v3 has been deprecated for now.
| @@ -90,7 +94,7 @@ jobs: | |||
| cp -r ./build/distributions/*.zip opensearch-observability-builds/ | |||
|
|
|||
| - name: Upload Artifacts | |||
| uses: actions/upload-artifact@v1 | |||
| uses: actions/upload-artifact@v3-node20 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix deprecated version of
actions/upload-artifact: v1see https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/
To introduce additional start command for all CI build which rely on the OpnSearch Docker image, as Github rollout the deprecation of the Node 16 on all it's CI-runner, as the result all existing Github which rely on the old version of Node.JS (Ex: actions/checkout@v3) failed due to the following errors:
The issue has been discovered over opensearch-project/opensearch-build#5178 and fix has been verified and applied on multiple OpenSearch plugin, such as:
Related Issues
Partially resolves: opensearch-project/sql#3168
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.