Modify call out text for discover #4932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
abbyhu2000
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
abbyhu2000
added
data explorer
kavilla
approved these changes
Sep 5, 2023
joshuarrrr
approved these changes
Sep 5, 2023
ashwin-pc
approved these changes
Sep 5, 2023
Codecov Report
@@ Coverage Diff @@
## main #4932 +/- ##
==========================================
- Coverage 66.39% 66.39% -0.01%
==========================================
Files 3397 3397
Lines 64807 64807
Branches 10361 10361
==========================================
- Hits 43029 43027 -2
- Misses 19218 19219 +1
- Partials 2560 2561 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@abbyhu2000 looks like tests all pass. should we merge? |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
* modify text on the legacy callout Signed-off-by: abbyhu2000 <[email protected]> * modify callout text for new discover Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> (cherry picked from commit 630b6c6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
abbyhu2000
pushed a commit
that referenced
this pull request
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify the call out texts based on UX input.
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr