Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Modify call out text for discover #4935

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 630b6c6 from #4932.

* modify text on the legacy callout

Signed-off-by: abbyhu2000 <[email protected]>

* modify callout text for new discover

Signed-off-by: abbyhu2000 <[email protected]>

---------

Signed-off-by: abbyhu2000 <[email protected]>
(cherry picked from commit 630b6c6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added the discover for discover reinvent label Sep 5, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot added the autocut Skip the changelog verification check on backports label Sep 5, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry distinguished-contributor labels Sep 5, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot added the data explorer Issues related to the Data Explorer project label Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #4935 (8e48ec5) into 2.x (fe367eb) will decrease coverage by 0.01%.
Report is 1 commits behind head on 2.x.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x    #4935      +/-   ##
==========================================
- Coverage   66.44%   66.43%   -0.01%     
==========================================
  Files        3398     3398              
  Lines       64873    64873              
  Branches    10359    10359              
==========================================
- Hits        43103    43101       -2     
- Misses      19212    19213       +1     
- Partials     2558     2559       +1     
Flag Coverage Δ
Linux_1 34.91% <ø> (ø)
Linux_2 55.18% <ø> (ø)
Linux_3 44.20% <ø> (-0.01%) ⬇️
Linux_4 35.09% <ø> (ø)
Windows_1 34.92% <ø> (ø)
Windows_2 55.15% <ø> (ø)
Windows_3 44.20% <ø> (-0.01%) ⬇️
Windows_4 35.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../public/application/components/discover_legacy.tsx 0.00% <ø> (ø)

... and 6 files with indirect coverage changes

@abbyhu2000 abbyhu2000 merged commit 6deddde into 2.x Sep 5, 2023
78 of 79 checks passed
@github-actions github-actions bot deleted the backport/backport-4932-to-2.x branch September 5, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports data explorer Issues related to the Data Explorer project discover for discover reinvent distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants