Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prte_setup_pmix.m4: check for specific PMIx capability flags #1854

Merged
merged 2 commits into from
Dec 13, 2023
Merged

prte_setup_pmix.m4: check for specific PMIx capability flags #1854

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f6e6f7
prte_setup_pmix.m4: check for specific PMIx capability flags
jsquyres Nov 18, 2023
8d5060a
Update capabilities detection
rhc54 Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions config/prte_setup_pmix.m4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,40 @@
# $HEADER$
#

dnl $1 is the base cap name (i.e., what comes after "PMIX_CAP_")
dnl $2 is the action if happy
dnl $3 is the action if not happy
AC_DEFUN([PRTE_CHECK_PMIX_CAP],[
PRTE_VAR_SCOPE_PUSH([prte_cpp_save])

AC_MSG_CHECKING([for PMIX_CAP_$1])

prte_cpp_save=$CPP
CPP="$PMIXCC_PATH -E"
AC_PREPROC_IFELSE(
[AC_LANG_PROGRAM([#include <pmix_version.h>],
[#if !defined(PMIX_CAPABILITIES)
#error This PMIx does not have any capability flags
#endif
#if !defined(PMIX_CAP_$1)
#error This PMIx does not have the PMIX_CAP_$1 capability flag at all
#endif
#if (PMIX_CAPABILITIES & PMIX_CAP_$1) == 0
#error This PMIx does not have the PMIX_CAP_$1 capability flag set
#endif
]
)
],
[AC_MSG_RESULT([found])
$2],
[AC_MSG_RESULT([not found])
$3])

CPP=$prte_cpp_save

PRTE_VAR_SCOPE_POP
])

AC_DEFUN([PRTE_CHECK_PMIX],[

PRTE_VAR_SCOPE_PUSH([prte_external_pmix_save_CPPFLAGS prte_pmix_support found_pmixcc])
Expand Down Expand Up @@ -136,6 +170,27 @@ AC_DEFUN([PRTE_CHECK_PMIX],[
AM_CONDITIONAL([PRTE_HAVE_PMIXCC], [test $found_pmixcc -eq 1])
AC_SUBST([PMIXCC_PATH])

# Check for any needed capabilities from the PMIx we found.
#
# Note: if the PMIx we found does not define capability flags,
# then it definitely does not have the capability flags we're
# looking for.

# For now, we just check for the "base" capability to exercise
# this feature - essentially retaining this as an example for
# future times when we actually need to check capabilities
PRTE_CHECK_PMIX_CAP([BASE],
[PRTE_PMIX_BASE_CAPABILITY=1],
[AC_MSG_WARN([Your PMIx version is either does not])
AC_MSG_WARN([the capabilities feature or does not])
AC_MSG_WARN([include the PMIX_CAP_BASE capability flag])
AC_MSG_WARN([Ignoring this for now])
PRTE_PMIX_BASE_CAPABILITY=0])

AC_DEFINE_UNQUOTED([PRTE_PMIX_BASE_CAPABILITY],
[$PRTE_PMIX_BASE_CAPABILITY],
[Whether or not PMIx has the BASE capability flag set])

PRTE_SUMMARY_ADD([Required Packages], [PMIx], [], [$prte_pmix_SUMMARY])

#
Expand Down