prte_setup_pmix.m4: check for specific PMIx capability flags #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhc54
force-pushed
the
pr/check-for-pmix-capability-flags
branch
from
18904ff to
bc7f1b1
Compare
Demo showing how to check for PMIx capability flags. This commit:
* Will abort configure if:
* PMIX_CAPABILITIES does not exist (i.e., this PMIx is so old that
it does not have any capability flags)
* PMIX_CAP_202311CLI capability flag goes not exist
* PMIX_CAP_202311CLI is not set in PMIX_CAPABILITIES
* Will warn if these capability flags are not set in PMIX_CAPABILITIES
(to include PMIX_CAPABILITIES not being defined at all, or either of
these flags not being defined at all):
* PMIX_CAP_SOMETHING_ELSE
* PMIX_CAP_BOGUS (which doesn't exist -- this simulates a new PRRTE
with an old PMIx)
Signed-off-by: Jeff Squyres <[email protected]>
Capability definition moved to pmix_version.h. Remove example usage and replace it with a simple check to exercise the code. Signed-off-by: Ralph Castain <[email protected]>
rhc54
force-pushed
the
pr/check-for-pmix-capability-flags
branch
from
5f4572a to
8d5060a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with openpmix/openpmix#3198
Demo showing how to check for PMIx capability flags. This commit:
Will abort configure if:
Will warn if these capability flags are not set in PMIX_CAPABILITIES (to include PMIX_CAPABILITIES not being defined at all, or either of these flags not being defined at all):