-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow zero follow-up times in DataDA objects. #851
Merged
Puzzled-Face
merged 11 commits into
main
from
850-datada-does-not-allow-zero-follow-up-time
Sep 30, 2024
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
05802bb
Allow zero follow-up times in DataDA objects.
Puzzled-Face afa0551
Fix version number in NEWS.md and update test results to reflect chan…
Puzzled-Face 1d0b03d
Fix new pkgdown errors.
Puzzled-Face 0d02e6e
update error message for invalid DataDA
Puzzled-Face f02a4d1
Fix URL in DESCRIPTION
Puzzled-Face 33345f0
Fix URL in DESCRIPTION
Puzzled-Face 3b6e087
Fix URL in DESCRIPTION
Puzzled-Face 295e283
Fix URL: in DESCRIPTION
Puzzled-Face 2a20040
Bump
Puzzled-Face 98eaa3a
Merge branch 'main' into 850-datada-does-not-allow-zero-follow-up-time
Puzzled-Face 7fef255
Update DESCRIPTION
Puzzled-Face File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
Package: crmPack | ||
Title: Object-Oriented Implementation of CRM Designs | ||
Version: 2.0.0.9160 | ||
Version: 2.0.0 | ||
Authors@R: c( | ||
person("Daniel", "Sabanes Bove", , "[email protected]", role = c("aut", "cre")), | ||
person("Wai", "Yin Yeung", , "[email protected]", role = "aut"), | ||
|
@@ -32,8 +32,8 @@ Description: Implements a wide range of model-based dose escalation | |
form in the S4 class system, making it very flexible for adaptation to | ||
new models, escalation or stopping rules. Further details are | ||
presented in Sabanes Bove et al. (2019) <doi:10.18637/jss.v089.i10>. | ||
License: GPL (>= 2) | ||
URL: https://github.com/openpharma/crmPack | ||
License: GPL (>= 2) | ||
URL: https://github.com/openpharma/crmPack, https://openpharma.github.io/crmPack/ | ||
BugReports: https://github.com/openpharma/crmPack/issues | ||
Depends: | ||
ggplot2 (>= 2.0.0), | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no worries about fixing this now, because the version bump action in GHA will change this again. we can just do it at the end before the CRAN release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version mismatch caused an error in the version check job of the CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, then please adjust the
DESCRIPTION
version instead of theNEWS
version