-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow zero follow-up times in DataDA objects. #851
Allow zero follow-up times in DataDA objects. #851
Conversation
This edit allows the test mentioned in #815 to pass locally. |
Code Coverage Summary
Diff against main
Results for commit: 7fef255 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
…ged reporting labels/slot names.
Unit Tests Summary 1 files 45 suites 2m 26s ⏱️ Results for commit 7fef255. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Results for commit a97b6e8 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Puzzled-Face , I think it should be ok to allow u = 0
times
@@ -1,4 +1,4 @@ | |||
# Version 2.0.0.9158 | |||
# Version 2.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no worries about fixing this now, because the version bump action in GHA will change this again. we can just do it at the end before the CRAN release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version mismatch caused an error in the version check job of the CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, then please adjust the DESCRIPTION
version instead of the NEWS
version
Close #850.