Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conditioned RTL with XLEN parameter #1579

Merged
merged 3 commits into from
Oct 31, 2023
Merged

conditioned RTL with XLEN parameter #1579

merged 3 commits into from
Oct 31, 2023

Conversation

fatimasaleem
Copy link
Contributor

@fatimasaleem fatimasaleem commented Oct 30, 2023 •
edited
Loading

@fatimasaleem fatimasaleem marked this pull request as ready for review October 31, 2023 06:13
@JeanRochCoulon
Copy link
Contributor

JeanRochCoulon commented Oct 31, 2023 •
edited
Loading

@AyoubJalali As you the person who identified the issue, can you approve the fix ?
In parallel, I will launch the CI

@github-actions
Copy link
Contributor

❌ failed run, report available here.

AyoubJalali
AyoubJalali reviewed Oct 31, 2023
View reviewed changes
core/alu.sv Outdated Show resolved Hide resolved
AyoubJalali
AyoubJalali reviewed Oct 31, 2023
View reviewed changes
core/alu.sv Outdated Show resolved Hide resolved
@AyoubJalali
Copy link
Contributor

@fatimasaleem LGTM, could check for other modules like compressed_decoder, mult ..., they have the same problem like that we have one PR resolving this one Issue

@AyoubJalali
Copy link
Contributor

LGTM @fatimasaleem Thanks

@github-actions GitHub Actions
Copy link
Contributor

✔️ successful run, report available here.

@JeanRochCoulon JeanRochCoulon merged commit a99f115 into openhwgroup:master Oct 31, 2023
11 checks passed
@AyoubJalali AyoubJalali mentioned this pull request Nov 13, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyoubJalali AyoubJalali AyoubJalali left review comments

@JeanRochCoulon JeanRochCoulon Awaiting requested review from JeanRochCoulon JeanRochCoulon is a code owner

@zarubaf zarubaf Awaiting requested review from zarubaf zarubaf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fatimasaleem @JeanRochCoulon @AyoubJalali