Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CVA6 Architecture overview Figure #1488

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

YazanHussnain-10x
Copy link
Contributor

This PR includes an updated version of the CVA6 Architecture Overview figure. The following changes have been made to the figure:

  • The Re-aligner has been moved to the Frontend.
  • Cache Subsystem (I$ and D$) have been moved outside the pipeline.
  • Signals have been added in the ID, Issue, and Commit stages, with labels for clarification.
  • An FPU has been added in the Execute stage.
  • The Division logic has been highlighted inside the Mult module.

These updates were made with the intention of preserving the originality of the figure.

@github-actions
Copy link
Contributor

❌ failed run, report available here.

1 similar comment
@github-actions
Copy link
Contributor

❌ failed run, report available here.

Copy link
Contributor

@zarubaf zarubaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Any chance we can also add the vector source file so that people can adapt it in case things change?

@fatimasaleem
Copy link
Contributor

Looks amazing! Any chance we can also add the vector source file so that people can adapt it in case things change?

Sure, we should add that, @YazanHussnain-10x can you add the source file in the same folder as well?

@YazanHussnain-10x
Copy link
Contributor Author

YazanHussnain-10x commented Sep 30, 2023

I added the vector file

@github-actions
Copy link
Contributor

❌ failed run, report available here.

@zarubaf
Copy link
Contributor

zarubaf commented Sep 30, 2023

Great that it is a drawio file.
Small hint: You can save the drawio as xyz.drawio.png that results in a pseudo png that can be displayed in the documentation and can be edited by drawio (so only one source file necessary). And I can also recommend the drawio vscode extension in case you don't know that one already :-)

@JeanRochCoulon
Copy link
Contributor

Hi @YazanHussnain-10x
Little feedbacks. The arrows are not all drawn with the same format: decoded instuction and valid for instance get the new format and signals from frontend are in old format. It would be great to uniformize the format. Cheers

@YazanHussnain-10x
Copy link
Contributor Author

@zarubaf, @JeanRochCoulon
Thanks for the suggestions and feedback. I have updated the figure and added the .drawio.png file.

@JeanRochCoulon JeanRochCoulon merged commit 6eea97f into openhwgroup:master Oct 2, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants