Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLU-309: [TILES-ATOMIC-INCREMENT-3] enhance multirow-multicol UI with custom styles and operators #819

Open
wants to merge 2 commits into
base: develop-v2
Choose a base branch
from

Conversation

pregnantboy
Copy link
Contributor

@pregnantboy pregnantboy commented Dec 16, 2024

TLDR;

FRONTEND-ONLY
For update-row action, allow users to set increment or decrement existing value.

image.png

What changed

  • Introduce 2 new attributes to dropdown fields, isSearchable and subFields.customStyles
  • if isSearchable is set to false, it prevent users from typing to search and center aligns the content (this is an existing prop that is unused)
  • subFields.customStyles allows users to override the container of the subfields in multirow-multicol fields

Why

This frontend change will allow users to change the way the value is modified, either set-as, add by or subtract by.

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Dec 16, 2024

Datadog Report

Branch report: fix/tiles/update-operator
Commit report: b973dac
Test service: plumber

✅ 0 Failed, 732 Passed, 0 Skipped, 2m 14.28s Total Time
⬆️ Test Sessions change in coverage: 1 increased (+0.04%)

@pregnantboy pregnantboy changed the title feat: wip PLU-819: [TILES-ATOMIC-INCREMENT-3] enhance multirow-multicol UI with custom styles and operators Dec 16, 2024
@pregnantboy pregnantboy marked this pull request as ready for review December 16, 2024 08:33
@pregnantboy pregnantboy requested a review from a team as a code owner December 16, 2024 08:33
@pregnantboy pregnantboy force-pushed the fix/tiles/update-operator branch 2 times, most recently from 28f2d0b to c85eb43 Compare December 16, 2024 08:40
@pregnantboy pregnantboy force-pushed the fix/tiles/make-update-row-atomic branch 2 times, most recently from 70affe9 to 8a1843f Compare December 19, 2024 06:57
@pregnantboy pregnantboy force-pushed the fix/tiles/update-operator branch from c85eb43 to 5bcb117 Compare December 19, 2024 06:58
@pregnantboy pregnantboy changed the base branch from fix/tiles/make-update-row-atomic to graphite-base/819 December 19, 2024 07:02
@pregnantboy pregnantboy force-pushed the fix/tiles/update-operator branch from 5bcb117 to 1abbf55 Compare December 19, 2024 07:03
@pregnantboy pregnantboy changed the base branch from graphite-base/819 to develop-v2 December 19, 2024 07:03
@pregnantboy pregnantboy force-pushed the fix/tiles/update-operator branch from 1abbf55 to 1a35e9f Compare December 19, 2024 07:03
@pregnantboy pregnantboy force-pushed the fix/tiles/update-operator branch from 1a35e9f to 8c961fa Compare December 24, 2024 06:31
Copy link
Contributor Author

@pregnantboy pregnantboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI to reviewers, this PR does not include backend changes (i.e. setting the operator to any value will still result in a "set as" operation)

@pregnantboy pregnantboy changed the title PLU-819: [TILES-ATOMIC-INCREMENT-3] enhance multirow-multicol UI with custom styles and operators PLU-309: [TILES-ATOMIC-INCREMENT-3] enhance multirow-multicol UI with custom styles and operators Dec 24, 2024
Copy link

linear bot commented Dec 24, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant