-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLU-309: [TILES-ATOMIC-INCREMENT-3] enhance multirow-multicol UI with custom styles and operators #819
base: develop-v2
Are you sure you want to change the base?
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 732 Passed, 0 Skipped, 2m 14.28s Total Time |
28f2d0b
to
c85eb43
Compare
70affe9
to
8a1843f
Compare
c85eb43
to
5bcb117
Compare
8a1843f
to
7e0773a
Compare
5bcb117
to
1abbf55
Compare
1abbf55
to
1a35e9f
Compare
1a35e9f
to
8c961fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI to reviewers, this PR does not include backend changes (i.e. setting the operator to any value will still result in a "set as" operation)
TLDR;
FRONTEND-ONLY
For update-row action, allow users to set increment or decrement existing value.
What changed
isSearchable
andsubFields.customStyles
isSearchable
is set to false, it prevent users from typing to search and center aligns the content (this is an existing prop that is unused)subFields.customStyles
allows users to override the container of the subfields inmultirow-multicol
fieldsWhy
This frontend change will allow users to change the way the value is modified, either set-as, add by or subtract by.