Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLU-817: [TILES-ATOMIC-INCREMENT-1] allowing copying of row id in tiles #817

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

pregnantboy
Copy link
Contributor

@pregnantboy pregnantboy commented Dec 16, 2024

TL;DR

Added ability to copy row IDs from the context menu in the table view

image.png

What changed?

  • Added a "Copy row ID" option to the context menu when a single row is selected
  • Displays a toast notification when a row ID is copied
  • Renamed internal state variable from rowIdsToDelete to rowIdsSelected for better clarity
  • Added BiCopy icon from react-icons library

How to test?

  1. Navigate to tile
  2. Right-click on a single row
  3. Click "Copy row ID" from the context menu
  4. Verify that:
    • A success toast appears
    • The row ID is copied to your clipboard
    • The option only appears when a single row is selected

Why make this change?

To improve user experience by making it easier to copy row IDs, which can be used in the "Update single row" step. This eliminates the need for Find single row if the user knows which row to update. This is mainly use for counters.

@pregnantboy pregnantboy marked this pull request as ready for review December 16, 2024 06:51
@pregnantboy pregnantboy requested a review from a team as a code owner December 16, 2024 06:51
@pregnantboy pregnantboy changed the title feat: allowing copying of row id in tiles PLU-817: [TILES-ATOMIC-INCREMENT-1] allowing copying of row id in tiles Dec 16, 2024
Copy link
Contributor

@kevinkim-ogp kevinkim-ogp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested and confirmed that copy row id works as expected 💪

Copy link
Contributor Author

pregnantboy commented Dec 19, 2024

Merge activity

  • Dec 19, 1:56 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 19, 1:57 AM EST: A user merged this pull request with Graphite.

@pregnantboy pregnantboy merged commit fd57521 into develop-v2 Dec 19, 2024
4 checks passed
@pregnantboy pregnantboy deleted the feat/tiles/allow-copying-row-id branch December 19, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants