Consider path when building up ilicache, fixes opengisch/QgisModelBaker#861 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll have a look. |
|
Great, thanks! You can check with the model so_afu_schutzbauten_20231212. This is a model in our repository with toppings in our Usability Hub. |
signedav
reviewed
Feb 9, 2024
There was a problem hiding this comment.
Thanks for your contribution!
I added a suggestion to make it more dynamic for other cases.
Btw. We do not only use the netloc variable for the path but always for other purposes (like as a key in the stored repository dict). I went through the code and it seems that adding the path does not affect the other cases, but to be sure I will test again after the final change.
|
Cool. Thanks @webrian |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@signedav this fixes opengisch/QgisModelBaker#861 for me, but please verify. Probably the additional slash could be dropped.