Wait for model refresh on local repository topping receive #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… local repository) to avoid that the model is not ready yet
domi4484
approved these changes
Feb 9, 2024
|
Waiting for new Library release after opengisch/QgisModelBakerLibrary#85 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had the functionality where we wait in a loop for the topping files to be downloaded. When there is a local repository, we did not wait for download (because the files where already there). But the model (where the mapping from id to file location is done) was sometimes not refreshed yet. That's why we wait for the signal in every case now.
And I renamed the signal in the library to avoid confusion.