feat: add models to associate an opportunity id with a subscription license #523
Conversation
muhammad-ammar
force-pushed
the
ammar/associate-opportunity-id-with-licenses
branch
5 times, most recently
from
65b6ca6 to
399420e
Compare
muhammad-ammar
changed the title
muhammad-ammar
force-pushed
the
ammar/associate-opportunity-id-with-licenses
branch
from
399420e to
c5416bf
Compare
muhammad-ammar
force-pushed
the
ammar/associate-opportunity-id-with-licenses
branch
from
c5416bf to
67eca35
Compare
| return "SubscriptionLicenseSourceType: Name: {name}, Slug: {slug}".format(name=self.name, slug=self.slug) | ||
|
|
||
|
|
||
| class SubscriptionLicenseSource(TimeStampedModel): |
There was a problem hiding this comment.
Minor suggestion: you might want HistoricalRecords on this model.
| related_name='source', | ||
| on_delete=models.CASCADE, | ||
| ) | ||
| source_id = models.CharField( |
There was a problem hiding this comment.
I'm thinking we should align the naming of these fields to what we use in subsidy: https://github.com/openedx/enterprise-subsidy/blob/main/enterprise_subsidy/apps/subsidy/models.py#L156-L176
There was a problem hiding this comment.
Playing devil's advocate a bit, having source_ in these names may make sense here given the model names both include Source (i.e., SubscriptionLicenseSource and SubscriptionLicenseSourceType)?
| related_name='source', | ||
| on_delete=models.CASCADE, | ||
| ) | ||
| source_id = models.CharField( |
There was a problem hiding this comment.
Playing devil's advocate a bit, having source_ in these names may make sense here given the model names both include Source (i.e., SubscriptionLicenseSource and SubscriptionLicenseSourceType)?
muhammad-ammar
force-pushed
the
ammar/associate-opportunity-id-with-licenses
branch
from
67eca35 to
d7d0714
Compare
muhammad-ammar
force-pushed
the
ammar/associate-opportunity-id-with-licenses
branch
from
55119e2 to
f9367ed
Compare
muhammad-ammar
deleted the
ammar/associate-opportunity-id-with-licenses
branch
Description
Add models to capture source of license assignment.
Link to the associated ticket: https://2u-internal.atlassian.net/browse/ENT-7641
Testing considerations
already been performed.
Post-review
Squash commits into discrete sets of changes