fix: override model save method to call full_clean

license_manager/apps/subscriptions/models.py

@@ -1341,6 +1341,13 @@ class SubscriptionLicenseSource(TimeStampedModel):
 
     history = HistoricalRecords()
 
+    def save(self, *args, **kwargs):
+        """
+        Override to ensure that model.clean is always called.
+        """
+        self.full_clean()
+        return super().save(*args, **kwargs)
+
     def __str__(self):
         """
         String representation of source.

license_manager/apps/subscriptions/tests/test_models.py

@@ -4,6 +4,7 @@
 
 import ddt
 import freezegun
+import pytest
 from django.forms import ValidationError
 from django.test import TestCase
 from requests.exceptions import HTTPError
@@ -434,3 +435,17 @@ def test_license_source_creation(self):
             license_uuid=self.active_current_license.uuid,
             source_id='000000000000000000',
         )
+
+    def test_license_source_creation_with_invalid_souce_id(self):
+        """
+        Verify that SubscriptionLicenseSource model raises exception if source id format is wrong.
+        """
+        with pytest.raises(ValidationError) as raised_exception:
+            SubscriptionLicenseSourceFactory(
+                license=self.active_current_license,
+                source_id='000000000',
+                source_type=SubscriptionLicenseSourceType.get_source_type(SubscriptionLicenseSourceType.AMT)
+            )
+
+        exception_message = ['Ensure this value has at least 18 characters (it has 9).']
+        assert raised_exception.value.args[0]['source_id'][0].messages == exception_message