Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade react router to v6 #174

Merged
merged 7 commits into from
Oct 18, 2023
Merged

Conversation

Syed-Ali-Abbas-Zaidi
Copy link
Contributor

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi commented Mar 20, 2023

Ticket

React Router Upgrade to v6.

Description

This PR upgrades React Router from v5 to v6.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi force-pushed the Ali-Abbas/react-router-upgrade branch from f8d279d to 1d49196 Compare August 29, 2023 06:37
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7afffa4) 100.00% compared to head (d1448de) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #174   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          110       110           
  Lines         1079      1079           
  Branches       159       159           
=========================================
  Hits          1079      1079           
Files Coverage Δ
src/index.jsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi marked this pull request as ready for review August 29, 2023 06:53
Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@mattcarter mattcarter merged commit b8f43b9 into master Oct 18, 2023
5 checks passed
@mattcarter mattcarter deleted the Ali-Abbas/react-router-upgrade branch October 18, 2023 15:33
bra-i-am pushed a commit to eduNEXT/frontend-app-ora-grading that referenced this pull request Nov 14, 2023
bra-i-am added a commit to eduNEXT/frontend-app-ora-grading that referenced this pull request Nov 14, 2023
bra-i-am pushed a commit to eduNEXT/frontend-app-ora-grading that referenced this pull request Apr 30, 2024
bra-i-am added a commit to eduNEXT/frontend-app-ora-grading that referenced this pull request May 2, 2024
* perf: add support of css-variables to quince

* feat: upgrade react router to v6 (openedx#174)

Co-authored-by: Matthew Carter <[email protected]>

---------

Co-authored-by: Syed Ali Abbas Zaidi <[email protected]>
Co-authored-by: Matthew Carter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants