Skip to content

Commit

Permalink
feat: upgrade react router to v6 (#174)
Browse files Browse the repository at this point in the history
Co-authored-by: Matthew Carter <[email protected]>
Syed-Ali-Abbas-Zaidi and mattcarter authored Oct 18, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent 7afffa4 commit b8f43b9
Showing 4 changed files with 41 additions and 82 deletions.
114 changes: 36 additions & 78 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -27,7 +27,7 @@
"@edx/brand": "npm:@edx/brand-openedx@^1.2.0",
"@edx/frontend-component-footer": "12.2.1",
"@edx/frontend-component-header": "4.6.0",
"@edx/frontend-platform": "4.6.3",
"@edx/frontend-platform": "5.6.1",
"@edx/paragon": "^20.44.0",
"@fortawesome/fontawesome-svg-core": "^1.2.36",
"@fortawesome/free-brands-svg-icons": "^5.15.4",
@@ -59,8 +59,8 @@
"react-intl": "^5.20.9",
"react-pdf": "^5.5.0",
"react-redux": "^7.2.9",
"react-router": "5.3.4",
"react-router-dom": "5.3.4",
"react-router": "6.15.0",
"react-router-dom": "6.15.0",
"react-router-redux": "^5.0.0-alpha.9",
"redux": "4.2.1",
"redux-beacon": "^2.1.0",
1 change: 1 addition & 0 deletions src/__snapshots__/index.test.jsx.snap
Original file line number Diff line number Diff line change
@@ -17,6 +17,7 @@ exports[`app registry subscribe: APP_READY. links App to root element 1`] = `
Symbol(Symbol.observable): [Function],
}
}
wrapWithRouter={false}
>
<App />
</AppProvider>
2 changes: 1 addition & 1 deletion src/index.jsx
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@ import App from './App';

subscribe(APP_READY, () => {
ReactDOM.render(
<AppProvider store={store}>
<AppProvider store={store} wrapWithRouter={false}>
<App />
</AppProvider>,
document.getElementById('root'),

0 comments on commit b8f43b9

Please sign in to comment.