-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(charts): move CRDs to a subchart #284
Conversation
c68670e
to
3be73e2
Compare
@niladrih You also need to change this file probably. https://github.com/openebs/lvm-localpv/blob/develop/deploy/lvm-operator.yaml and then we can go for a test? |
Put it in a different PR: #286 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #284 +/- ##
============================================
+ Coverage 23.50% 98.29% +74.79%
============================================
Files 12 1 -11
Lines 3008 529 -2479
============================================
- Hits 707 520 -187
+ Misses 2288 5 -2283
+ Partials 13 4 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1e809bf
to
d7d4c71
Compare
Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Jeffrey Zhang <[email protected]> Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Abhinandan Purkait <[email protected]> Signed-off-by: Niladri Halder <[email protected]>
) Signed-off-by: Evgenii Tereshkov <[email protected]> Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Evgenii Tereshkov <[email protected]> Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Niladri Halder <[email protected]>
Signed-off-by: Niladri Halder <[email protected]>
Changes:
PRs with similar change: