feat(charts): disable hostNetwork on node plugin #280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhinandan-Purkait
force-pushed
the
disable_hostNetwork
branch
from
9d32c03
to
701d4db
Compare
Abhinandan-Purkait
requested review from
niladrih,
abhilashshetty04 and
avishnu
and removed request for
niladrih
Abhinandan-Purkait
changed the title
Signed-off-by: Abhinandan Purkait <[email protected]>
Abhinandan-Purkait
force-pushed
the
disable_hostNetwork
branch
from
701d4db
to
ee7b10c
Compare
abhilashshetty04
approved these changes
Jan 24, 2024
avishnu
approved these changes
Jan 24, 2024
|
#284 Cherry-picked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #274
This allows hostNetwork on lvm-csi-node to be configurable, with default as false.