Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button misplacmenet in the comment section and cleanup css #565

Conversation

marwyg
Copy link
Member

@marwyg marwyg commented Jun 4, 2024

Fixes #540

This PR adds some CSS flex to rearrange the button and the selectbox. Furthermore it cleans up some css that seem to have no effect and makes the selectbox a little bit larger (because why not, there is plenty of room).

Copy link
Contributor

github-actions bot commented Jun 4, 2024

This pull request is deployed at test.admin-interface.opencast.org/565/2024-06-04_11-40-02/ .
It might take a few minutes for it to become available.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-565

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-565

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@jduehring
Copy link
Contributor

Looks good to me and works as expected.

@luniki luniki assigned jduehring and unassigned jduehring Jun 4, 2024
@luniki luniki requested a review from jduehring June 4, 2024 11:51
@marwyg marwyg mentioned this pull request Jun 4, 2024
@marwyg
Copy link
Member Author

marwyg commented Jun 4, 2024

My removed CSS seems to break the view, when you click on "reply". See #527 as reference. I will make another commit for this PR to enhance the styling of the "reply" view.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

This pull request is deployed at test.admin-interface.opencast.org/565/2024-06-04_12-24-39/ .
It might take a few minutes for it to become available.

@marwyg
Copy link
Member Author

marwyg commented Jun 4, 2024

I kept the big checkbox against this comment: #527 (comment) because of accessibility reasons. What do you think?

Nonetheless, the reply view looks like this now:
grafik

@marwyg
Copy link
Member Author

marwyg commented Jun 4, 2024

It's ready for review

Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Got one question though: Why use CSS order? Could we not just order the elements correctly in EventDetailsCommentsTab?

@marwyg
Copy link
Member Author

marwyg commented Jun 4, 2024

I thought about this. But I am not sure if I might break something and I found out, that it's possible to change order with CSS ;) But if you prefer the other way I try it out.

@Arnei
Copy link
Member

Arnei commented Jun 4, 2024

I would avoid ordering with CSS unless necessary in order to keep with convention and keep it simple.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

This pull request is deployed at test.admin-interface.opencast.org/565/2024-06-04_14-06-54/ .
It might take a few minutes for it to become available.

@marwyg
Copy link
Member Author

marwyg commented Jun 4, 2024

I reordered the elements in the TSX now.

@Arnei Arnei merged commit 28424e8 into opencast:main Jun 4, 2024
5 checks passed
@marwyg marwyg deleted the fix/issue-540-misplaced-submit-button-in-event-details branch June 4, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:visual-clarity Improves UI readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misplaced submit button in Event Details -> Comments section
3 participants