-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix button misplacmenet in the comment section and cleanup css #565
Fix button misplacmenet in the comment section and cleanup css #565
Conversation
This pull request is deployed at test.admin-interface.opencast.org/565/2024-06-04_11-40-02/ . |
Use Run test server using develop.opencast.org as backend:
Specify a different backend like stable.opencast.org:
It may take a few seconds for the interface to spin up. |
Looks good to me and works as expected. |
My removed CSS seems to break the view, when you click on "reply". See #527 as reference. I will make another commit for this PR to enhance the styling of the "reply" view. |
This pull request is deployed at test.admin-interface.opencast.org/565/2024-06-04_12-24-39/ . |
I kept the big checkbox against this comment: #527 (comment) because of accessibility reasons. What do you think? |
It's ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me. Got one question though: Why use CSS order
? Could we not just order the elements correctly in EventDetailsCommentsTab?
I thought about this. But I am not sure if I might break something and I found out, that it's possible to change order with CSS ;) But if you prefer the other way I try it out. |
I would avoid ordering with CSS unless necessary in order to keep with convention and keep it simple. |
This pull request is deployed at test.admin-interface.opencast.org/565/2024-06-04_14-06-54/ . |
I reordered the elements in the TSX now. |
Fixes #540
This PR adds some CSS flex to rearrange the button and the selectbox. Furthermore it cleans up some css that seem to have no effect and makes the selectbox a little bit larger (because why not, there is plenty of room).