Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several save-button misplacements in the event and series details #572

Merged

Conversation

marwyg
Copy link
Member

@marwyg marwyg commented Jun 4, 2024

This PR fixes several button misplacements when editing data in the event and series details:

  • Event Metadata
  • Event Extended Metadata
  • Event Scheduling
  • Event Workflow
  • Event ACL
  • Series Metadata
  • Series Themes
  • Series ACL
  • maybe more

Fixes (at least): #531, #527 and #570

To test, click through all possible tabs of existing events, series (and maybe something else?) and change data. Then take a look on the save and cancel button if something is misplaced.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

This pull request is deployed at test.admin-interface.opencast.org/572/2024-06-04_13-34-15/ .
It might take a few minutes for it to become available.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-572

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-572

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@ferishili
Copy link
Contributor

ferishili commented Jun 4, 2024

Please add #570 here as well
Series ACL should also be affected, if not please check!

@ziegenberg
Copy link
Member

Nice, we even got testing instructions! 🥳

@marwyg
Copy link
Member Author

marwyg commented Jun 4, 2024

Please add #570 here as well Series ACL should also be affected, if not please check!

The series ACL should be corrected, too.

@ziegenberg
Copy link
Member

This is still broken on Event/Comments

image

@marwyg
Copy link
Member Author

marwyg commented Jun 4, 2024

This is still broken on Event/Comments

image

There were another Issue for this #540 and should be fixed with this PR #565

@ziegenberg
Copy link
Member

Yeah, I just saw #565.

Copy link
Member

@ziegenberg ziegenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now.

@ziegenberg ziegenberg merged commit 51822e7 into opencast:main Jun 4, 2024
6 of 7 checks passed
@ziegenberg ziegenberg self-assigned this Jun 4, 2024
@marwyg marwyg deleted the fix/issue-531-event-details-save-button branch June 4, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:visual-clarity Improves UI readability
Projects
None yet
3 participants