Add event upload progress #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use notifications to show the progress of an event upload. In order for this to work, this adds the ability to add notifications with certain ids, as well as the ability to override notifications.
|
Looks good. You now receive immediate feedback that the event is being uploaded and something is happening. One thing: When I upload an event, the notification comes, but without the percentage. Surely the progress should also be displayed? Or did I miss something?
|
|
Should absolutely display a percentage. Will currently only work when setting your Opencast to en_US, as it relies on changes in the translation files (and I only made those changes in the en_US file). |
Whoops, I guess I picked the wrong flag then when testing this :D With en_US this works like expected. Nice |
narickmann
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use notifications to show the progress of an event upload. In order for this to work, this adds the ability to add notifications with certain ids, as well as the ability to override notifications.