Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(benchmark): write benchmark results to file #4172

Merged
merged 1 commit into from
Oct 1, 2023
Merged

fix(benchmark): write benchmark results to file #4172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
- name: Benchmark tests
run: |
npm run test:bench
find . -name benchmarks.txt -exec cat {} + > combined_benchmarks.txt
find . -name .benchmark-results.txt -exec cat {} + > combined_benchmarks.txt

- name: Store benchmark results
uses: benchmark-action/github-action-benchmark@v1
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,3 +89,6 @@ package.json.lerna_backup
#IDEA
.idea
*.iml

# non-aggregated benchmark results
.benchmark-results.txt
2 changes: 1 addition & 1 deletion packages/opentelemetry-sdk-trace-base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"test": "nyc ts-mocha -p tsconfig.json 'test/**/*.test.ts' --exclude 'test/browser/**/*.ts'",
"test:browser": "karma start --single-run",
"test:webworker": "karma start karma.worker.js --single-run",
"test:bench": "node test/performance/benchmark/index.js",
"test:bench": "node test/performance/benchmark/index.js | tee .benchmark-results.txt",
"tdd": "npm run tdd:node",
"tdd:node": "npm run test -- --watch-extensions ts --watch",
"tdd:browser": "karma start",
Expand Down