Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(benchmark): write benchmark results to file #4172

Merged

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Sep 29, 2023

Which problem is this PR solving?

Benchmark workflow is currently failing because individual benchmark results are not written to file. This PR makes it so that benchmark results are written to .benchmark-results.txt and adds .benchmark-results.txt to .gitignore.

Related #4171

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #4172 (0bffc31) into main (c84698d) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 0bffc31 differs from pull request most recent head 5c9a206. Consider uploading reports for the commit 5c9a206 to get more accurate results

@@            Coverage Diff             @@
##             main    #4172      +/-   ##
==========================================
+ Coverage   92.24%   92.25%   +0.01%     
==========================================
  Files         331      331              
  Lines        9465     9465              
  Branches     1997     1997              
==========================================
+ Hits         8731     8732       +1     
+ Misses        734      733       -1     

see 1 file with indirect coverage changes

Copy link
Contributor

@martinkuba martinkuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this!

@pichlermarc pichlermarc merged commit 868f75e into open-telemetry:main Oct 1, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants