Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start resolution menu at current resolution #3801

Conversation

Zedb0T
Copy link
Contributor

@Zedb0T Zedb0T commented Dec 10, 2024

Also run cpp and goal formatter

Fixes #1623

@xTVaser
Copy link
Member

xTVaser commented Dec 10, 2024

This doesn't really fix #1632 because it only applies to the resolution menu. Unless I am misremembering and this is the only menu like this in Jak 1?

I do have changes in progress that are getting close to fully refactoring Jak 1's menu code (and fixing that along with 4+ other issues)

In the future, you might want to put full-project formatting changes in a separate PR as well, makes something simple much harder to review.

@Zedb0T
Copy link
Contributor Author

Zedb0T commented Dec 10, 2024

Ah alright, I tired to split it out into two commits my apologies.
04a3818

@Zedb0T
Copy link
Contributor Author

Zedb0T commented Dec 10, 2024

Also yeah I guess I got baited by the discussion in the issue. I see now that its more of a global scope and its probably better to make all menus behave in this manner somehow.

@Zedb0T Zedb0T closed this Dec 10, 2024
@Hat-Kid
Copy link
Member

Hat-Kid commented Dec 10, 2024

Also don't run the GOAL formatter on textures.gc or tpages.gc. The formatter currently inserts newlines between every top-level statement so it just inflates the line count for those files.

@xTVaser
Copy link
Member

xTVaser commented Dec 10, 2024

You didn't have to close it, if it works and is an improvement. But up to you.

@Zedb0T
Copy link
Contributor Author

Zedb0T commented Dec 10, 2024

Nah, I'm only doing it to save you guys time and to learn a bit. If you have something in progress that fixes this and more, then I am not saving any time. And I've already succeeded on the learning part 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

jak1: progress menu lists dont open with the current selected option focused
3 participants