Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Component base class for code refactoring #983

Merged
merged 8 commits into from
Dec 10, 2024
Merged

Add Component base class for code refactoring #983

merged 8 commits into from
Dec 10, 2024

Conversation

lvliang-intel
Copy link
Collaborator

Description

Add Component base class for code refactoring

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

None

Tests

Local test and pre-CI test.

@lvliang-intel
Add Component base class
bc68f68 
Signed-off-by: lvliang-intel <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.09524% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comps/cores/common/component.py 88.09% 5 Missing ⚠️
Files with missing lines Coverage Δ
comps/cores/common/component.py 88.09% <88.09%> (ø)

... and 1 file with indirect coverage changes

lvliang-intel and others added 6 commits December 9, 2024 17:59
@lvliang-intel lvliang-intel merged commit c409ef9 into opea-project:main Dec 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@letonghan letonghan letonghan approved these changes

@Spycsh Spycsh Spycsh approved these changes

@XinyaoWa XinyaoWa Awaiting requested review from XinyaoWa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lvliang-intel @Spycsh @letonghan