Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQL agent strategy #975

Merged
merged 38 commits into from
Dec 11, 2024
Merged

Conversation

minmin-intel
Copy link
Collaborator

@minmin-intel minmin-intel commented Dec 6, 2024

Description

Add sql_agent_llama strategy

Issues

#976

Type of change

List the type of change like below. Please delete options that are not relevant.

  • New feature (non-breaking change which adds new functionality)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

@minmin-intel minmin-intel requested review from lkk12014402 and xuechendi and removed request for lvliang-intel December 6, 2024 00:43
@minmin-intel
Copy link
Collaborator Author

UT tests sql_agent_llama on Gaudi.
I tested in my local system using openai model for sql_agent and passed. See screenshot below.
image

Copy link
Collaborator

@xuechendi xuechendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@lkk12014402 lkk12014402 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minmin-intel minmin-intel merged commit c36c503 into opea-project:main Dec 11, 2024
14 checks passed
@joshuayao joshuayao linked an issue Dec 12, 2024 that may be closed by this pull request
@ftian1
Copy link
Collaborator

ftian1 commented Dec 12, 2024

this PR is not correct. it introduces a symblic link in root dir and add a data_hub. it's not allowed. pls revert it @minmin-intel

minmin-intel added a commit that referenced this pull request Dec 12, 2024
lvliang-intel pushed a commit that referenced this pull request Dec 14, 2024
jjmaturino pushed a commit to jjmaturino/GenAIComps that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sql agent strategy
4 participants