-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor multimodal embedding code #968
Open
lvliang-intel
wants to merge
6
commits into
opea-project:main
Choose a base branch
from
lvliang-intel:embedding_reorg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lvliang-intel <[email protected]>
Signed-off-by: lvliang-intel <[email protected]>
Signed-off-by: lvliang-intel <[email protected]>
Signed-off-by: lvliang-intel <[email protected]>
lvliang-intel
requested review from
srinarayan-srikanthan,
letonghan and
XinyaoWa
December 4, 2024 06:45
35 tasks
Signed-off-by: lvliang-intel <[email protected]>
opea-project/GenAIExamples#1244 is created to update the dockerfile path. |
letonghan
approved these changes
Dec 10, 2024
Spycsh
approved these changes
Dec 10, 2024
chensuyue
reviewed
Dec 15, 2024
@@ -16,7 +16,7 @@ unset http_proxy | |||
function build_mmei_docker_images() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scripts name should align with the microservice path.
intel_cpu
is the default device, don't need to add it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor multimodal embedding code
Issues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
None
Tests
Local test and CI test.