Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor multimodal embedding code #968

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

lvliang-intel
Copy link
Collaborator

Description

Refactor multimodal embedding code

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

None

Tests

Local test and CI test.

Signed-off-by: lvliang-intel <[email protected]>
Signed-off-by: lvliang-intel <[email protected]>
Signed-off-by: lvliang-intel <[email protected]>
@lvliang-intel
Copy link
Collaborator Author

opea-project/GenAIExamples#1244 is created to update the dockerfile path.

@lvliang-intel lvliang-intel requested a review from Spycsh December 10, 2024 02:17
@@ -16,7 +16,7 @@ unset http_proxy
function build_mmei_docker_images() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scripts name should align with the microservice path.
intel_cpu is the default device, don't need to add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants