Migration Suggestion #959
Migration Suggestion #959
Conversation
The directory layout suggest for helm charts in GenAIComps Signed-off-by: Dolpher Du <[email protected]>
Corresponding "GenAIExamples" repo PR: opea-project/GenAIExamples#1218 Uses Helm repo deps like: How often charts from this repo would be synced there (on every merge, daily, weekly?) i.e. how much this would complicate (testing of) features that need changes to both repos? |
| | image.repository | string | `"opea/llm-tgi"` | | | ||
| | service.port | string | `"9000"` | | | ||
| | TGI_LLM_ENDPOINT | string | `""` | LLM endpoint | | ||
| | global.monitoring | bool | `false` | Service usage metrics | |
There was a problem hiding this comment.
Helm install fails if user enables this without reading the docs first => Just removing link to doc is not a solution!
Neither is duplicating the docs in multiple repos.
=> IMHO best would be to move common Helm chart docs (on HPA, monitoring etc) to helm-charts dir here, and link those from all relevant docs (including Helm chart READMEs going to Examples repo).
|
As to other CI failures... Clearly pre-CI |
|
@eero-t Thanks. This is just a PR draft created to show possible dir layout, doesn't mean the final decision. So, many issues are not resolved yet. |
The directory layout suggest for helm charts in GenAIComps
Description
The summary of the proposed changes as long as the relevant motivation and context.
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.