Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Retriever qdrant issue #476

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

letonghan
Copy link
Collaborator

Description

Fix Retriever qdrant issue.
Return [] for empty retrieved docs.

Issues

The CI failed here for ChatQnA qdrant.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

None

Tests

CI test

Signed-off-by: letonghan <[email protected]>
@letonghan letonghan requested a review from XuhuiRen as a code owner August 13, 2024 08:39
@letonghan letonghan merged commit 7aee7e4 into opea-project:main Aug 14, 2024
8 checks passed
BaoHuiling pushed a commit to siddhivelankar23/GenAIComps that referenced this pull request Aug 15, 2024
BaoHuiling pushed a commit to siddhivelankar23/GenAIComps that referenced this pull request Aug 15, 2024
Signed-off-by: letonghan <[email protected]>
Signed-off-by: BaoHuiling <[email protected]>
tileintel pushed a commit to siddhivelankar23/GenAIComps that referenced this pull request Aug 22, 2024
Signed-off-by: letonghan <[email protected]>
Signed-off-by: siddhivelankar23 <[email protected]>
sharanshirodkar7 pushed a commit to predictionguard/pg-GenAIComps that referenced this pull request Sep 3, 2024
@letonghan letonghan deleted the retriever/qdrant branch September 23, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants