Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact embedding/ranking/llm request/response by referring to openai format #405

Merged
merged 8 commits into from
Aug 12, 2024

Conversation

lkk12014402
Copy link
Collaborator

@lkk12014402 lkk12014402 commented Aug 5, 2024

Description

define embedding/ranking/llm request/response by referring to OpenAI format

related pr and pr

  1. Compatible with previous implementation, plus custom template
  2. Microservice becomes independent
  3. Parameters such as template and retrieval can be customized
  4. Use openai to wrap endpoint, allow openai completion/chat request, and openai response at the same time
  5. llm parameters are consistent with openai default parameters

@lkk12014402 lkk12014402 requested review from Spycsh and removed request for ftian1 August 5, 2024 00:38
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 98.31933% with 2 lines in your changes missing coverage. Please review.

Files Patch % Lines
comps/cores/mega/gateway.py 0.00% 1 Missing ⚠️
comps/cores/proto/docarray.py 87.50% 1 Missing ⚠️
Files Coverage Δ
comps/cores/proto/api_protocol.py 93.02% <100.00%> (+3.13%) ⬆️
comps/cores/mega/gateway.py 23.43% <0.00%> (-2.06%) ⬇️
comps/cores/proto/docarray.py 98.94% <87.50%> (-1.06%) ⬇️

... and 3 files with indirect coverage changes

@lkk12014402 lkk12014402 requested a review from XuhuiRen as a code owner August 6, 2024 10:46
@chensuyue chensuyue merged commit 7287caa into main Aug 12, 2024
39 checks passed
@chensuyue chensuyue deleted the refact_openai_format branch August 12, 2024 15:24
BaoHuiling pushed a commit to siddhivelankar23/GenAIComps that referenced this pull request Aug 15, 2024
BaoHuiling pushed a commit to siddhivelankar23/GenAIComps that referenced this pull request Aug 15, 2024
…format (opea-project#405)

Co-authored-by: sys-lpot-val <[email protected]>
Co-authored-by: lvliang-intel <[email protected]>
Signed-off-by: BaoHuiling <[email protected]>
sharanshirodkar7 pushed a commit to predictionguard/pg-GenAIComps that referenced this pull request Sep 3, 2024
lkk12014402 pushed a commit that referenced this pull request Sep 19, 2024
* Add DocIndexRetriever example

Signed-off-by: Chendi.Xue <[email protected]>


---------

Signed-off-by: Chendi.Xue <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: XuhuiRen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants