Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reorg] Remove redundant file in retrievers/redis #1016

Merged
merged 11 commits into from
Dec 17, 2024

Conversation

letonghan
Copy link
Collaborator

Description

Remove redundant file in retrievers/redis.
Including ingest.py, upload pdf file, and multimodal folder.

Issues

#1014

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

None

Tests

None

@letonghan letonghan added this to the v1.2 milestone Dec 9, 2024
@joshuayao joshuayao linked an issue Dec 10, 2024 that may be closed by this pull request
@letonghan letonghan force-pushed the reorg/retriever_multi branch from efdc413 to e440307 Compare December 10, 2024 06:26
@letonghan letonghan marked this pull request as ready for review December 10, 2024 07:32
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
@letonghan letonghan requested a review from Spycsh December 10, 2024 08:30
@letonghan
Copy link
Collaborator Author

The CI issue is caused by reference from GenAIExample.
This PR is ready now, will wait for @chensuyue to force merge.

@chensuyue
Copy link
Collaborator

The CI issue is caused by reference from GenAIExample. This PR is ready now, will wait for @chensuyue to force merge.

Ok, please paste the GenAIExample PR here.

@letonghan
Copy link
Collaborator Author

GenAIExamples fix Dockerfile reference issue PR: opea-project/GenAIExamples#1252

@chensuyue chensuyue merged commit f3aaaeb into opea-project:main Dec 17, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] remove redundant retrievers file
4 participants