[pull] develop from ethereum-optimism:develop #573

* refactor: Move interop e2e test contracts to e2eutils/interop. * refactor: Move interop e2e test contracts to e2eutils/interop/contracts.

* interop-devnet: add grafana/loki/promtrail Revival of PR #11628 to enhance local interop devnet. Co-authored-by: Ethen Pociask <[email protected]> Co-authored-by: Samuel Laferriere <[email protected]> * interop-devnet: use custom grafana port * interop-devnet: fix ports * interop-devnet: enable op-supervisor metrics --------- Co-authored-by: Ethen Pociask <[email protected]> Co-authored-by: Samuel Laferriere <[email protected]>

Co-authored-by: Matthew Slipper <[email protected]>

Adds a new semgrep rule that blocks the usage of public functions in libraries. We don't use linked libraries and they cause issues with foundry.

)

* use RWMap for Supervisor Backend * adjust Clear method

The ConnectedF callback was sending to a channel that was only ever read from once. This causes the test to time out under certain conditions.

This is one of our flakiest tests since it's very dependent on the test runner's CPU usage.

…12787) Bumps [github.com/kurtosis-tech/kurtosis/api/golang](https://github.com/kurtosis-tech/kurtosis) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/kurtosis-tech/kurtosis/releases) - [Changelog](https://github.com/kurtosis-tech/kurtosis/blob/main/CHANGELOG.md) - [Commits](kurtosis-tech/kurtosis@1.4.0...1.4.1) --- updated-dependencies: - dependency-name: github.com/kurtosis-tech/kurtosis/api/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Adds a new deployment script for deploying a new dispute game implementation.

…2803)

…il the derivation is idle (#12804) * op-e2e: Add action test for op-program trace extension behaviour. * op-program: Run until all events are exhausted instead of running until the derivation is idle.

* Add Holocene action tests * fix invalid batch tests * Handle rpc.Errors directly instead of relying on eth.InputErrors The fault proof program's L2 Engine API doesn't return eth.InputErrors, like the sources engine client, but directly returns rpc.Errors. So instead of relying on this translation, derivers need to deal directly with rpc.Errors. * In TryBackupUnsafeReorg, only reset on InvalidForkchoiceState error code * Add logs * include genesis FPP tests --------- Co-authored-by: Sebastian Stammler <[email protected]>

* Change the name * Update op-challenger/README.md Co-authored-by: smartcontracts <[email protected]> --------- Co-authored-by: smartcontracts <[email protected]>

* feat(semgrep): add sol-force-require-msg rule Signed-off-by: jsvisa <[email protected]> * feat(semgrep): exclude packages temporary Signed-off-by: jsvisa <[email protected]> * feat(semgrep): add testcase Signed-off-by: jsvisa <[email protected]> * test script example Signed-off-by: jsvisa <[email protected]> * require msg more clear Signed-off-by: jsvisa <[email protected]> --------- Signed-off-by: jsvisa <[email protected]>

* cannon: Add godoc to ExecMipsCoreStepLogic * update MIPS64.sol * update semver

This updates the markdown table in security-reviews/README.md to: 1. Correct the scope of the 2024-03 Sherlock audit to Fault Proofs. 2. Rename pdfs to match the existing convetion 3. Fix Reviewer attribution on the Mips and no Mips audits.

* cannon: Add post-state assertions * cannon: Bump MIPS64 contract version

* op-deployer: Fix useInterop flag * set interop offset

* feat: add IERC7802 (#123) * feat: add IERC7802 * fix: token address fuzz error * feat: remove ERC165 contract inheritance * feat: add IERC20 interface support (#124) * feat: add IERC20 interface support * fix: interfaces tests

* Moved meta files to a new folder * doctoc POLICY * fix versioning * remove doctoc on versioning

…5.1 (#12816) Bumps [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt) from 4.5.0 to 4.5.1. - [Release notes](https://github.com/golang-jwt/jwt/releases) - [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md) - [Commits](golang-jwt/jwt@v4.5.0...v4.5.1) --- updated-dependencies: - dependency-name: github.com/golang-jwt/jwt/v4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* op-supervisor: fix data race in test This test is flaky in CI. I believe it may be related to a data race: the `count` variable was being read from/written to across multiple threads which could lead to invalid data being read by the test. I verified that the data race was gone by running the test with `-race`. * Use >= rather than exact numbers

Kills old folders that aren't used anymore.

* op-deployer: Add support for alt-DA deployments Gives users the ability to deploy an alt-DA chain by specifying an alt-DA config in their chain's intent. The chain will be deployed using OPCM, then an additional pipeline step will deploy the alt-DA challenge contracts. The owner of the challenge contract is set to the L1 proxy admin owner. To reflect the experimental nature of this feature, the field in the intent is prefixed with `Dangerous`. Users should not use this for production chains until we have performed further testing. This may not appear like an important feature on its surface. However, without it we cannot delete the legacy allocs files. Since it was low lift I figured I'd just knock it out, and get us one step closer to being able to rip out the legacy deployment scripts and tooling once and for all. * semgrep * forge fmt * label * flip args

* Add error case for parent of start of database * fix unit tests

…#12810) In this situation, the blocks get another chance to be put into a channel, when the metric will be decremented. This leads to inaccurate (even negative) metrics.

* implement throttling feedback loop based on the amount of data pending for DA settlement * make ThrottleInterval of 0 indicate do not start throttling loop * use modular batcher e2esys config * disable batcher throttling by default --------- Co-authored-by: Sebastian Stammler <[email protected]>

)

* op-deployer: Add deploy mips script * op-deployer: Explicitly set the PreimageOracle to use with deployed MIPS * op-deployer: Validate mips version in go code.

* chore(op-deployer): use goreleaser-pro schema This avoids getting schema validation errors wherever pro features are used. * chore: bump goreleaser-pro to 2.4.3 No functional change, just good hygiene.

Excessive backslashing made the command invalid. Also address the lint-shellcheck current discoveries.

Moves the semgrep folder back into .semgrep now that we worked out how to actually execute the tests when they're located inside of a hidden folder.

This job is CPU-heavy, and causes other workflows to fail due to resource exhaustion. This PR moves this job onto a dedicated Latitude runner and resource class. The resource class is configured so that it can only run one job at a time, which is fine since this job only runs on commits to develop.

@notice

* feat: Isthmus Contracts work squashed remove unused import fix: IOptimismMintableERC721 interface feat: move semver out of abstract OptimismMintableERC20Factory Also add spacer after _initialized/ing fix: Initializer check in DeployOPChain fix: CrossDomainOwnable3 test feat: update semver-lock feat: Add systemConfigAdmin to deploy-config fix: IL1BlockInterop iface fix: update devnetL1-template fix: casing on systemConfigFeeAdmin feat: update ConfigType names feat: rename setHolocene to setL1BlockValuesIsthmus feat: refine setL1BLockValuesIsthmus to read fee vault config directly from getters. fix: read remoteChainId from ERC721 Factory, not Bridge feat: Update test_setL1BlockValuesIsthmus_isDepositor_succeeds to compare with cfg feat: use setIsthmus() * debug: Add fee admin to intent * fix: fee vault immutable checks no longer necessary * fix: TestConfigDataMarshalUnmarshal * fix: immutable check for L2ProxyAdmin owner * fix: SystemConfigFeeAdmin naming in opchain.go * feat: op-deployer - get SystemConfigFeeAdmin from intent.Roles * remove dead comments * feat: resolve feeAdmin setting todo coment * feat: move unsafeBLockSigner into SystemConfig.Roles struct * feat: move batcherHash into SystemConfig.Roles struct * fix: Add missing feeAdmin setter in DeployOpChain test * fix: SystemConfig.init in specs * feat: resolve todo * feat: resolve some todos * feat: Natspec in StaticConfig * feat: resolve some todos * fix: test_getConfigRoundtripGasPayingToken_succeeds with normalizeSmallString * pre-pr * test: Implement roll and reset prevBought gas in SystemConfig Test's cleanStorageAndInit() * feat: Add natspec on SystemConfig.Roles * feat: Fix all incomplete @notice natspec comments * feat: systemConfigFeeAdmin name in opcm * rebuild snapshots * Add ArtifactsFromURL utility * add configurability to createEnv * clean up env.go * fix apply test * fix: TestInteropDeployment * fix: TestApplyExistingOPCM * fix: unchecked return on checkImmutable * fix: goimports env.go * fix: Add devkey for SystemConfigFeeAdmin * fix: TestInteropDeployment * fix: TestInteropDevRecipe * feat: use base CDM interface in L1Block * feat: configure L1 Block config values in L2Genesis * feat: document Isthmus upgrade transactions on `setIsthmus()` * semver fixes * feat: L2 Genesis with cheated config in L1Block * ok: how'd those warnings get in there in the first place? * chore: update semver-lock * works * allocs build, cfg calls commented out cuz they fail * fix: read DeployConfig before it gets deleted * fix: test_allocs_size * fix: restore l1 deps * fix: test_getConfigRoundtripGasPayingToken_succeeds disallow eth address * fix: update test_proveWithdrawalTransaction_benchmark Unclear why this cost changed? * feat: Add Isthmus to Config.sol * feat: hoist L1Block population above allocs writes * chore: delete debug logs * WIP: update SystemConfig bindings and go usage * fix: go linting * feat: deposit setGasPayingToken as first call in SystemConfig.init * semver lock * TODO in L2Genesis * chore: semver * fix: Remove outdated comments * feat: extract logic into _setNetworkConfig() * test: Add total gas usage test * remove dead comment * ci: reduce heavy fuzz runs temporarily --------- Co-authored-by: Matthew Slipper <[email protected]>

* interop: Geth Mempool Filter E2E Test * use latest op-geth rc * fix AtLeastAsSafe * fix test

* op-supervisor: do not return zeroed included-in block * op-supervisor: fix tests, implement review suggestion

…12869)

* Revert "feat: Isthmus Contracts (#12746)" This reverts commit dad1087. * temporarily reduce heavy fuzz runs

* make custom process bash function * rm Executables.sol, fix failing test * fixes * fixes...

…2805) * apply exclude in test name checks and add it to ci and just check * rename names/ to test-names/ * add and use no build test names check command * apply test name checks to half of excludes test files * apply test name checks to last half of excludes test files

* merge bridge initializer into common test * gas snapshot * remove duplicate import

* Don't prepend blocks in reverse order * Fix memory leak

* add semgrep rule sol-style-no-bare-imports and implement it * write test for bare imports rule * fix forge fmt on semgrep test * fix bare import * semver lock * fix semver

* add semgrep check to checks and rename check-foundry-install to check-dep-install * fixes * fixes

* convert semver lock to go * updae just file * delete old semver lock file * fixes * move snapshot files to snapshots folder * fixes * fix check-semver-diff

Attempt at fixing the ongoing test flakiness with the batcher tests. Makes two changes: - Waits for the L1 to be up for all end-to-end tests to mitigate the I/O and context timeouts we've been seeing. - Update the multi batcher test to use an algorithm that's more tolerant of when the L1 doesn't immediately include the transaction.

…for conductor endpoint (#12863) * op-conductor,op-node: allow system to select port, make op-node wait for conductor endpoint * op-conductor,op-node: debugging conductor test * op-conductor: more debugging * op-e2e: increase conductor timeout

* fix double error in inferring isHolocene * add capture logging to l2faultproofenv * fold log expectations into holoceneExpectations * improve test failure output * attach log expectations to invalid batch test case * add more log expectations * add more log expectations * add more test expectations for invalid payloads * add log assertion for deposits-only attributes * improve test names * improve subtest names * move holocene helpers to separate file * remove shadow * add log assertions for holocene_batches_test.go * remove assertion on logs in frame queue

* confirm holocene activation behavior TODO remove hack around setting holocene time TODO add log assertions * add holocene_activation_test.go * move holocene time hardcoding into test override * tidy * Update op-e2e/actions/proofs/holocene_activation_test.go Co-authored-by: clabby <[email protected]> --------- Co-authored-by: clabby <[email protected]>

* cannon: Add more 64-bit tests * address review comments

* improve L1 contracts code cov * improve L1 contracts code cov * improve L1 contracts code cov * improve L1 contracts code cov * improve L1 contracts code cov * improve L1 contracts code cov

…rol (#11919) * op-chain-ops: state forking, Go script forking, cheatcode access-control * add forking unit tests * goimports * linter * fix state dump * Add script test, hammer out bugs * semgrep ignore scripts * op-chain-ops: script state dump test * fix merge error * goimports --------- Co-authored-by: Matthew Slipper <[email protected]>

* feat:add bne test Signed-off-by: Chen Kai <[email protected]> * feat:Add sll/srl/sra/sllv/srlv/srav/jr/jalr/beq/bne mips test Signed-off-by: Chen Kai <[email protected]> * Apply suggestions from code review Co-authored-by: mbaxter <[email protected]> * fix:add code review suggestion Signed-off-by: Chen Kai <[email protected]> --------- Signed-off-by: Chen Kai <[email protected]> Co-authored-by: mbaxter <[email protected]>

* cannon: Add differential tests for lui instruction * cannon: Add clo, clz differential tests

* feat(ctb): Holocene upgrade package * lint * lint * add example env to sc-ops task * fix * reuse `SystemConfig` and `MIPS` impls optionally * optionally deploy a new `DelayedWETH` proxy + impl add check * env lint * add docker image to docker tag service * kelvin idiot-proofing ask * fetch standard config addresses for Holocene * lint * ajsutton review: Deploy separate DelayedWETH proxies for the FDG/PDG * ajsutton review: Conditional FDG usage * use contracts rc tag * mds review * split `SystemConfig` and proofs contracts upgrades * add option to completely disclude the fault proof contracts fix * Update README * verify * deploy config * fix contract tag * README update * semgrep

* cannon: Add version 3 state and enable detect test * cannon: Get other DetectVersion tests running

* improve tests * improve tests * fixes

* fix: semver locking. * fix: semver locking. * feat: opcm impl contracts now type safe. * feat: fixing test. * fix: removing unused imports. * fix: address didn't need to be payable. * fix: moving all smart contract changes to first pr. * fix: pr comments addressed. * fix: removed InputContracts struct. * fix: ran pre-pr * fix: deploy implementations renaming version. * fix: adding solidity changes to this pr. * fix: adding v160 initializer back in. * fix: removed branching logic from opcm. * fix: removed SystemConfigV160. * opcm-redesign: op-deployer changes * fix: linting fix. * fix: semver lock --------- Co-authored-by: Matthew Slipper <[email protected]>

* remove unnecessary check * fixes

* ensure bcast.From == mgr.From() * address comment * fix for create2

* op-batcher: fix channel duration timeout management Previously, we would use L1 data to help track channel durations. For example, the batcher would be configured to post data every hour. We update a global state variable with the latest l1 origin of a channel when it closed, and compute the deadline for that channel using a duration delta starting at that l1 origin timestamp. Since we changed the way autoDA switching works, a channel can be _closed_ (due to a duration timeout or other reason) and this will cause the l1 origin state variable to move forward, extending the deadline ready for the next channel. Crucially, with autoDA switching nowadays, the closed channel will not always be submitted on chain (it can be discarded and the blocks requeued). If it is discarded, the channel duration timeout has already been extended. The fix for this is to update the global state variable at channel submission time, not channel closing time. * add regression test for channel duration timeouts during requeue

…reorg handling (#12390) * use a queue.Queue for channelBuilder.frames * remove pop and push terminology * proliferate queue.Queue type * simplify requeue method * undo changes to submodule * sketch out new arch https://www.notion.so/oplabs/op-batcher-re-architecture-114f153ee162803d943ff4628ab6578f * add TODO * add channelManager.pruneSafeBlocks method and integrate into main loop * fix frameCursor semantics * fixup tests * avoid Rewind() in tests * only rewind cursor in rewind (never move it forward) * fix assertions * prune channels whose blocks are now safe * handle case when rewinding a channel with no blocks this is strange, I don't think we should expect channels with frames but no blocks... * add clarification * implement channelManager.pendinBlocks() method * fix pruning logic * simplify pruneChannels * simplify pruneSafeBlocks * add unit tests for pruneSafeBlocks * fix pruneSafeBlocks to avoid underflow * improve test * add unit tests for pruneChannels * introduce handleChannelTimeout and simplify channel.TxConfirmed API * factor out channelManager.rewindToBlockWithHash * change test expectation * do more pruning in test * Replace "clean shutdown" behaviour with waitNodeSync() Instead of optimizing for a clean shutdown (which we couldn't guarantee anyway), this change optimizes for code simplicity. This change also helps us restrict the amount of code which mutates the channelQueue (removePendingChannel was doing removal of channels at arbitrary positions in the queue). The downside is that we may end up needlessly resubmitting some data after the reset. Reorgs are rare, so it makes sense to optimize for correctness rather than DA costs here. * Add readme and architecture diagram * don't panic when there is a safe chain reorg * fix test * readability improvements * only clear state after waiting for node to sync * resize image * tweak readme * typo * rewindToBlockWithHash never moves cursor forward * use s.pendingBlocks() * add log line * check there are blocks when handling timeout * rename HasFrame() to HasPendingFrame() * fixup test * improve readme * link to open issues by tag * add log when main loop returns * pass blockID to rewindToBlock and panic if block does not exist * don't remove all channels when a channel times out keep older channels, it's possible that they also time out * use newSafeHead.L1Origin in Clear() when pruning blocks * clarify comment * use warn log level on safe chain reorg pruning, and unify handling for safe head above unsafe head * update panic message * extend test coverage and fix bug * rename test blocks * simplify HasPendingFrame() method * simplify implementation of RewindFrameCursor * activate dormant test * ensure pending_blocks_bytes_current metric is tracked properly * cover metrics behaviour in test using new TestMetrics struct * extend test coverage to channelManager.handleChannelTimeout * add comment to TxFailed * rename test fn * point to e2e tests in readme. * readme: performance -> throughput * improve channel_manager_test to assert old channels are not affected by requeue or timeout * fix handleChannelTimeout behaviour We were trimming older channels and keeping new ones. We need to trim newer channels and keep old ones. Fixes associated test (see previous commit). * tighten up requirements for invalidating a channel * replace requeue with handleChannelInvalidated

* removing duplicate default bootnode * adding conduit bootnodes * removing duplicate bootnode

* feat:Add more sync tests Signed-off-by: Chen Kai <[email protected]> * feat:add more sync tests Signed-off-by: Chen Kai <[email protected]> * fix:fix failed tests Signed-off-by: Chen Kai <[email protected]> * fix:add copyright credit and remove unused code Signed-off-by: Chen Kai <[email protected]> * fix:fix copyright format Signed-off-by: Chen Kai <[email protected]> * fix code review suggestions Signed-off-by: Chen Kai <[email protected]> --------- Signed-off-by: Chen Kai <[email protected]>

Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.8.0 to 0.9.0. - [Commits](golang/sync@v0.8.0...v0.9.0) --- updated-dependencies: - dependency-name: golang.org/x/sync dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix upgrade-semgrep * fix upgrade-semgrep

- Refactor the semver inspector so that it can be called from outside the CLI - Adds a a canonical L2 genesis file for v1.6.0, and a unit test to assert that new chains deployed using v1.6.0 have the right L2 genesis.

* improve tests * fixes * fixes... * Apply suggestions from code review Co-authored-by: smartcontracts <[email protected]> * fixes --------- Co-authored-by: smartcontracts <[email protected]>

* improve tests * fixes * fixes * fixes * Apply suggestions from code review Co-authored-by: smartcontracts <[email protected]> * fixes --------- Co-authored-by: smartcontracts <[email protected]>

* fix challenge struct natspec * semver bump * semver bump * semver bump

* security-reviews: Add 3Doc report on Canon F_GETFD changes. * security-reviews: Update README.

Fix typo in build script comment for clarity

CI must passing should be CI must pass.

- fixing the audit commits and descriptions so they map correctly

Fix typo in comment for Keccak256Commitment.Encode method

* typo corr 2022-02-02-inflation-vuln.md * typo corr README.md * typo corr RUNBOOK.md

* flatten out batcher goroutines * move wg increment to parent fn * ensure mainloop closes before receipts loop * add comments * pass a context to both loops * remove debug lines * clean up mutex handling in receiptsLoop * don't need to set default value the first time * avoid writing to Logger while holding mutex * typo * increase log level and include tx.ID * fix changes from merge, hoist throttling loop goroutine launch to driver * call done on waitgroup in throttlingLoop * move function around hoping this makes the diff nicer

…on (#12966)

* implement batchSubmitter.checkExpectedProgress * remove buffer variable * add warning logs when calling waitNodeSyncAndClearState * push method down into channel manager and add test * clarify SyncStatus documentation * improve TestChannelManager_CheckExpectedProgress make parameters "tighter" / more realistic and check an extra case

…#12919) * Reset Derivation when Supervisor is Behind * Disable Batcher Throttling in Interop local-devnet

Adds a unit test for mainnet deployments at version 1.6.0.

* interop: make geth Dockerfile use rc5 * use rc6 * Update ops-bedrock/l2-op-geth-interop.Dockerfile

It has been 6 months since we removed the package and added the redirect. Anybody that has not learned where it is at this point will be able to search Github and find a link to this commit.

Co-authored-by: Samuel Laferriere <[email protected]>

Update the op-deployer Dockerfile to install CA certificates and symlink /op-deployer into /usr/local/bin so that it's on the container's PATH.

* migrate close-stale github action * using external script * completing script * removing old github action * example only * removing versions * removing tag-service

* feat(ctb): `RISCV.sol` semver-lock Co-Authored-By: Minhyuk Kim <[email protected]> Co-Authored-By: Taem Park <[email protected]> Co-Authored-By: Park Changwan <[email protected]> Co-Authored-By: protolambda <[email protected]> * snapshots * diff with remote in CI * schedule diff job * Update .circleci/config.yml Co-authored-by: Matt Solomon <[email protected]> * remove check changed --------- Co-authored-by: Minhyuk Kim <[email protected]> Co-authored-by: Taem Park <[email protected]> Co-authored-by: Park Changwan <[email protected]> Co-authored-by: protolambda <[email protected]> Co-authored-by: Matt Solomon <[email protected]>

* improve delayedWeth test and coverage * improve delayedWeth test and coverage * fix DataAvailabilityChallenge failing fuzz test

* improve universal and libraries tests and coverage * fixes

Bumps ethereum/client-go from v1.14.11 to v1.14.12. --- updated-dependencies: - dependency-name: ethereum/client-go dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* contracts: remove op-nft Remove the `op-nft` package from the contracts package. None of these contracts are maintained and can be moved to another repo if necessary. The purpose of this commit is to reduce compilation time. Less files to compile means less compilation time. * fix: semver lock step - ran pre-pr. * fix: use added/modified filter for heavy fuzz Updates the heavy fuzz filter for CI to only check for added or modified contracts, now excluding deleted or moved contracts. --------- Co-authored-by: Blaine Malone <[email protected]> Co-authored-by: Kelvin Fichter <[email protected]>

* improve optimismportal(2) test coverage * improve optimismportal(2) test coverage * more tests, fixes

* improve dispute game tests and coverage * fixes

…12983) Bumps [github.com/kurtosis-tech/kurtosis/api/golang](https://github.com/kurtosis-tech/kurtosis) from 1.4.1 to 1.4.2. - [Release notes](https://github.com/kurtosis-tech/kurtosis/releases) - [Changelog](https://github.com/kurtosis-tech/kurtosis/blob/main/CHANGELOG.md) - [Commits](kurtosis-tech/kurtosis@1.4.1...1.4.2) --- updated-dependencies: - dependency-name: github.com/kurtosis-tech/kurtosis/api/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* op-node: Create metrics to record if sequencer is active * op-node: Update transactions_sequenced_total metric --------- Co-authored-by: protolambda <[email protected]>

- Enables support for deploying tagged versions against new chains, but behind a huge warning that requires user input to bypass. Since our tagged release versions do not contain all implementations, using op-deployer in this way will deploy contracts that haven't been governance approved. Since this workflow is useful for development but bad for prod, I've added support for it but users have to bypass a large warning that describes the risks. - Validates the hashes of tagged version artifacts after downloading them. This prevents users from downloading tampered versions of the artifacts from GCS.

* make riscv compile without the optimizer turned on * bump riscv.sol * bump riscv.sol

Test hard fork offset overrides Co-authored-by: Vinod Damle <[email protected]>

…ations (#13012) This is adding op-program/v1.4.0-rc.1 with absolute prestate hash 0x03925193e3e89f87835bbdf3a813f60b2aa818a36bbe71cd5d8fd7e79f5e8afe to the releases.json file. This release contains Sepolia Holocene activation times for OP, Base, Mode, Zora, BUT NOT Metal.

* build: add just modules A lot of our build recipes share similar structures. Move some of these to modules so we can control them centrally. * build: add Makefile deprecation helper This allows us to implement deprecated Makefiles as: DEPRECATED_TARGETS := ... include ../just/deprecate.mk * build(docker): add just modules to docker context We need to make sure our build framework is included in the docker build context. Also make sure just is part of the builder image. * build(op-batcher): migrate build to just

* cannon: Port go map tests * cannon: Port pool_test.go * cannon: Port a few more mutex tests * cannon: Port waitgroup_test.go * cannon: Port oncefunc_test.go (in progress) * cannon: Port atomic_test.go (in progress) * cannon: Port value_test.go (in progress) * cannon: Fix atomic tests by using a test mock * cannon: Fix test fail behavior * cannon: Move test util to a shared module * cannon: Use common testutil throughout * cannon: Fix failing tests * cannon: Add sanity check test program for test runner utils * cannon: Add more util tests, fix step counts * cannon: Rename test util method * cannon: Fix panic, error handling in testutil * cannon: Dedupe test running code * cannon: Simplify testutil interface * cannon: Mark mt tests as slow * cannon: Cut debugging code from test * cannon: Validate gc complete output * cannon: Synchronize access to bool values

* improve DeployerWhitelist test * fix L1BlockNumber fallback test * fixes

* fix a deadlock * add comment

This reverts commit 8f5c20e.

* op-node: log mgasps across block processing lifecycle * op-node: add 'import_time' field to block processing log * op-node: make log message more descriptive * op-node: log legacy codepath for InsertUnsafePayload * op-node: include final ForkchoiceUpdate in block insertion time * op-node: remove unused BuildTime field from events * op-node: encapsulate log logic in TryUpdateEngineEvent methods * op-node: linter fix * op-node: add comment and adjust sync log wording * op-node: fix BlockHash, BlockNumber in log * op-node: seq add BuildStarted to PayloadProcessEvent * op-node: refactor getBlockProcessingMetrics, protect against divide-by-zero

The tests in the txmgr queue were asserting that calls complete within a certain time window. This was causing flakes, particularly when the CI runner was under load. Generally we should avoid tests that use fixed durations as a way of asserting that code functions correctly.

lint-forge-tests-check-no-build was causing issues in CI because it was running as part of contracts-bedrock-checks which depends on contracts-bedrock-build. contracts-bedrock-build builds the contract files EXCEPT for tests whenever contracts-bedrock has changed. This means that contracts-bedrock-build would not build any test files and therefore lint-forge-tests-check-no-build would not find any test files to check and the job would do nothing. However, when contracts-bedrock is NOT changed, the build job gets the full set of artifacts INCLUDING test artifacts from the cache. This would trigger the full check to actually be run and it would properly fail. This PR moves that particular check into contracts-bedrock-tests so that it's guaranteed to have all of the compiled contracts.

Moves the task for linting test names to after the tests job so that the contract artifacts actually exist. We don't compile everything ahead of time and rely on forge test to do the compilation in an effort to cut down total compile time.

Co-authored-by: Michael Amadi <[email protected]>

* ctb: Fix Holocene upgrade script * improve README * pass deploy-config as parameter to just run, other improvements * remove commented-out variables

* improve drippie & faucet tests and coverage * Update packages/contracts-bedrock/test/periphery/faucet/Faucet.t.sol Co-authored-by: smartcontracts <[email protected]> * Update packages/contracts-bedrock/test/periphery/faucet/Faucet.t.sol Co-authored-by: smartcontracts <[email protected]> --------- Co-authored-by: smartcontracts <[email protected]>

Most of the time there's no output from our Go tests, it means there's a bug. Lowering the timeout here will reduce the amount of time we spend waiting for jobs to fail. For long-running tests like fault proofs, the value is configured at 20m since those tests take longer.

* add test for L1ChugSplashProxy * fixes * fixes

* add LegacyMintableERC20 tests * fixes

* ci: Convert all Go tests into a single job Takes all the go-e2e and go-test jobs and combines them into one single super-job. This has the following benefits: 1. We can centralize all config for Go tests in one place and simplify our CI pipeline. 2. It leaves parallelism up to the Go runtime, which is more efficient. 4. It makes our test reporting more accurate. As part of this PR, I also: 1. Created a new resource class just for Go tests. It runs on the large Latitude runner, but limits the number of parallel go test jobs to 3 to prevent resource starvation. 2. Enabled test retries on `gotestsum`. This should reduce the number of flakes we see from the Go tests by retrying them up to 2 times in the event that they fail. Failures are still captured by the test reporting, so we can address them. * code review updates

* fix: use eth_getBlockReceipts for Infura RPC kind * fix infura test

Signed-off-by: chuangjinglu <[email protected]>

* op-deployer: Add a proxy to handle RPC failures Anvil is very finnicky when it comes to RPC responses. It'll blow up if it encounters any HTTP error, and does not support retries. This PR adds a locally-hosted proxy which sits between Anvil and the fork RPC source and handles retries automatically. * lint * lint again * ignore lint

…0.0 (#13075) Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.9.0 to 1.10.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.9.0...v1.10.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: delete unused deploy functions * feat: Delete some more unused code * fix: Unused imports

Cleans up import statments in all contracts within the src/ directory. We should probably add a semgrep rule or a check that confirms that everything looks good. I'll leave that part for another commit.

* feat: delete unused deploy functions * feat: Delete some more unused code * fix: Unused imports * feat: reorder Deploy.s.sol helpers

Requires moving from ethclient.Client to sources.L1Client since ethclient.Client requires a *rpc.Client which doesn't have any support for request timeouts.

Now that multiple test processes are running at once, multiple threads are compiling the op-program client in the tests. This PR builds the client upfront to avoid this condition.

This was causing flakes.

Sometimes, disconnection events happen after the sync client is closed. This can (among other things) lead to panics in tests due to logs occurring after the test has exited. This PR makes RemovePeer a noop when `s.closingPeers == true`, which is the same functionality as `AddPeer`.

… `holocene_time` (#13098) * update superchain-registry dependency brings in the unichain sepolia holocene_time * update dependency on op-geth

…pt (#13087)

* op-deployer: Load CLI options into the bootstrap disputegame config * op-deployer: Simplify bootstrap disputegame to only deploy the disputegame contract

Restores the correct asterisc RISCV bytecode, moves the contract to the vendor folder, and changes CI so that it performs the check on the asterisc bytecode when attempting to merge into develop.

When the op-node is closed, it also closes the P2P node. To prevent future usage, `n.p2pNode` is set to `nil`. However, the AsyncGossiper can still sometimes send gossip messages to the `OpNode` struct after close. Since `n.p2pNode` is `nil` at this point, the node would panic. This PR updates the `OpNode` implementation to check for this case. Access is protected via a mutex to prevent concurrency problems.

Very small cleanup of the foundry config file.

Bumps [github.com/minio/minio-go/v7](https://github.com/minio/minio-go) from 7.0.80 to 7.0.81. - [Release notes](https://github.com/minio/minio-go/releases) - [Commits](minio/minio-go@v7.0.80...v7.0.81) --- updated-dependencies: - dependency-name: github.com/minio/minio-go/v7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

) Bumps [github.com/multiformats/go-multiaddr-dns](https://github.com/multiformats/go-multiaddr-dns) from 0.4.0 to 0.4.1. - [Release notes](https://github.com/multiformats/go-multiaddr-dns/releases) - [Commits](multiformats/go-multiaddr-dns@v0.4.0...v0.4.1) --- updated-dependencies: - dependency-name: github.com/multiformats/go-multiaddr-dns dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

op-program supports custom configs identified by chain ID so make sure op-challenger can pass through a chain ID option even if it isn't a known network.

Fixes a flake that existed inside of the SuperchainWETH test suite. Was caught by the heavy fuzz test.

* op-deployer: add config-intent-type * op-deployer: revert name change of GasLimit * op-deployer: add Intent.setStandardValues and Intent.validateStandardValues * op-deployer: improve standard intent-config err messages * op-deployr: chain intent custom err types * op-deployer: add unit test for inent.validateStandardValues * linter fix * add intent-config-type custom * add intent-config-type strict * add intent-config-type standard-overrides,strict-overrides * refactor intent.ConfigType validation methods, add intent NewIntent* funcs * add TestValidateCustomValues, refactor contract tag check * remove duplicate chainIntent.Check() code * fix SuperchainRoles.ProxyAdminOwner for standard chains

…13129)

* build(just): factor out flags code This will enable making use of JUSTFLAGS in the main Makefile for migrated targets. * fix(just): parallel support For some unclear reason runs in CI environment are invalid (they generate some "empty" calls to the private target). Sidestep the issue for now. * build(just): add more helpers - VERSION_META variable - go_generate target * build(op-proposer): migrate build to just * build(op-node): migrate build to just * fix(build): rewire just-migrated targets --------- Co-authored-by: Matthew Slipper <[email protected]>

* feat(op-deployer): `asterisc` bootstrap CLI * rename file * flags * mslipper review * golint --------- Co-authored-by: Matthew Slipper <[email protected]>

…ix (#13132)

* remove lastStoredBlock and lastL1Tip from BatchSubmitter state We can use the channelManager's state to infer lastStoredBlock. And lastL1Tip is actually unused. * change log line wording * fix typo * remove unecessary method * clean up driver.calculateL2BlockRangeToStore * some typos * tiny tweak

Various things in the primary justfile weren't particularly legible, particularly around installing tooling versions. Cleans up the primary justfile so that everything has comments and the process for installing tooling is unified. Co-authored-by: Matthew Slipper <[email protected]>

* update lib keccak dependency * update semver-lock * update semver-lock

* txmgr: Queue.Send() uses q.txMgr.SendAsync This should ensure that transactions are confirmed on chain in the order Queue.Send() is called, without sacrificing parallel tx submission. * implement SendAsync in op-challenger test stubTxMgr It doesn't preserve the nonces like the production txMgr does. * TrySend also ensures synchronous tx nonce ordering (on success) * factor out HandleResponse fn * remove unused code * unexport handler

…13117)

Adds the ability to supply arguments to the "just test" recipe in the contracts package. Developers frequently need to add arguments to test specific contracts and running "just test" as the unified testing command is better than flipping to "forge test".

There was one other spot where the batcher would log after tests exit, causing a panic.

* Update README.md * Update README.md * Update README.md

Fixes the stack-too-deep error in the PermissionedDisputeGame by updating the game to use a struct as the constructor parameter.

…ng (#13124) * add additional assertions to test to check for tx ordering * enhance test to handle tx confirmation ID ordering * increase size of 0th tx to expose race condition * change approach since the backend does not order txs by nonce * tidy * clarify * Update op-service/txmgr/queue_test.go Co-authored-by: Sebastian Stammler <[email protected]> --------- Co-authored-by: Sebastian Stammler <[email protected]>

* SendDepositTx: make applyL2Opts nil-able * move maxBlobs closer to used place * fix typo

When any of the setup transactions in `TestInterop_EmitLogs` fail to be mined, the test hangs until it times out. See [here](https://app.circleci.com/pipelines/github/ethereum-optimism/optimism/73118/workflows/b48debaa-55bc-4138-a419-a87c236cbc58/jobs/2994655/artifacts) for an example. This PR updates the SuperSystem API to take a context from the test itself to allow for timeouts.

* disable forge coverage in ci * disable forge coverage in ci * disable forge coverage in ci

Updates the Cannon libraries to be version agnostic instead of being pinned to 0.8.15. This is OK because we do not deploy libraries outside of contracts that have pinned contract versions.

Introduces a new common base framework for writing contracts check scripts in Go. Many of the check scripts basically do the exact same logic of somehow parsing either the interfaces or the artifact files. Goal of this small project is to make the process of writing new checks easier and more reliable. We demonstrate this framework in action by porting the test-names script to use this new framework.

Introduces mise for polyglot tool dependency management.

Golang map iteration order is random, so we need to sort first.

…d signing (#12325) * Initial implementation of integrating op-node with op-signer for remote signer configuration for block payload signing * op-service: remove the requirement for signer.address to be set when using op-service * op-service: add blockpayload_args to send to rpc opsigner_signBlockPayload * Implement mock rpc in gossip_test and apply review * Clean up tests

* feat: remove unused onlyTestnetOrDevnet modifier * feat: remove unused _includeDump arg

* remove done todo from just file * remove done todo from just file

…y in ci (#13171)

Removes the legacy versions.json file and replaces it with references to mise.toml.

Tests are flaking because the batcher's txmgr still polls for receipts after shutdown. Those polls emit logs, which then cause the tests to panic. To fix, I updated the batcher shutdown code to wait for all pending transactions in the tx queue to complete.

* op-deployer/ctb: Add DeployOPCM script Adds a dedicated script to deploy OPCM for use with a future op-deployer bootstrap command. We'll use this for the Holocene deployment. * Update packages/contracts-bedrock/test/opcm/DeployOPCM.t.sol Co-authored-by: blaine <[email protected]> * Update packages/contracts-bedrock/test/opcm/DeployOPCM.t.sol Co-authored-by: blaine <[email protected]> * remove unused import * forgot an import --------- Co-authored-by: blaine <[email protected]>

* op-e2e: Recover gracefully from log-after-exit panics There are a lot of places where we log after tests exit. This PR recovers from those panics so tests can continue. * add helper

* chore(opc): Bump `asterisc` version * semver lock

* build(op-supervisor): migrate build to just * build(op-service): migrate build to just * build(op-conductor): migrate build to just * build(op-wheel): migrate build to just * build(op-challenger): cleanup visualize target The referenced visualize.sh script doesn't exist. It was moved around and finally deleted in #12286 * build(op-challenger): migrate build to just * build(op-chain-ops): migrate build to just * build(op-dispute-mon): migrate build to just * build(op-alt-da): migrate build to just

Bumps the version of forge/cast/anvil being used in the monorepo.

* chore(ops): add support for the op-challenger to run kona + asterisc * fix: update docker bake * fixes

Workaround for a bug? feature? in foundry that causes it to nuke whatever snapshots directory you have configured. Since this now defaults to "snapshots" it was nuking our snapshots folder.

…type` option (#13208)

Commits on Nov 24, 2024

fixes (#13052 )

AmadiMichael authored Nov 24, 2024

Configuration menu

View commit details

Copy full SHA for 7719c85

Browse repository at this point

Copy the full SHA

7719c85 View commit details

Browse the repository at this point in the history

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pull] develop from ethereum-optimism:develop #573

[pull] develop from ethereum-optimism:develop #573

Commits on Nov 1, 2024

Commits on Nov 2, 2024

Commits on Nov 4, 2024

Commits on Nov 5, 2024

Commits on Nov 6, 2024

Commits on Nov 7, 2024

Commits on Nov 8, 2024

Commits on Nov 11, 2024

Commits on Nov 12, 2024

Commits on Nov 13, 2024

Commits on Nov 14, 2024

Commits on Nov 15, 2024

Commits on Nov 16, 2024

Commits on Nov 17, 2024

Commits on Nov 18, 2024

Commits on Nov 19, 2024

Commits on Nov 20, 2024

Commits on Nov 21, 2024

Commits on Nov 22, 2024

Commits on Nov 23, 2024

Commits on Nov 24, 2024

Commits on Nov 25, 2024

Commits on Nov 26, 2024

Commits on Nov 27, 2024

Commits on Nov 28, 2024

Commits on Nov 29, 2024

Commits on Nov 30, 2024

Commits on Dec 2, 2024

Commits on Dec 3, 2024

Commits on Dec 4, 2024

[pull] develop from ethereum-optimism:develop #573

Are you sure you want to change the base?

[pull] develop from ethereum-optimism:develop #573

Commits on Nov 1, 2024

Commits on Nov 2, 2024

Commits on Nov 4, 2024

Commits on Nov 5, 2024

Commits on Nov 6, 2024

Commits on Nov 7, 2024

Commits on Nov 8, 2024

Commits on Nov 11, 2024

Commits on Nov 12, 2024

Commits on Nov 13, 2024

Commits on Nov 14, 2024

Commits on Nov 15, 2024

Commits on Nov 16, 2024

Commits on Nov 17, 2024

Commits on Nov 18, 2024

Commits on Nov 19, 2024

Commits on Nov 20, 2024

Commits on Nov 21, 2024

Commits on Nov 22, 2024

Commits on Nov 23, 2024

Commits on Nov 24, 2024

Commits on Nov 25, 2024

Commits on Nov 26, 2024

Commits on Nov 27, 2024

Commits on Nov 28, 2024

Commits on Nov 29, 2024

Commits on Nov 30, 2024

Commits on Dec 2, 2024

Commits on Dec 3, 2024

Commits on Dec 4, 2024