This repository has been archived by the owner on Dec 5, 2021. It is now read-only.
[pull] develop from ethereum-optimism:develop #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
pull
bot
added
merge-conflict
Various things in the primary justfile weren't particularly legible, particularly around installing tooling versions. Cleans up the primary justfile so that everything has comments and the process for installing tooling is unified. Co-authored-by: Matthew Slipper <[email protected]>
* update lib keccak dependency * update semver-lock * update semver-lock
* txmgr: Queue.Send() uses q.txMgr.SendAsync This should ensure that transactions are confirmed on chain in the order Queue.Send() is called, without sacrificing parallel tx submission. * implement SendAsync in op-challenger test stubTxMgr It doesn't preserve the nonces like the production txMgr does. * TrySend also ensures synchronous tx nonce ordering (on success) * factor out HandleResponse fn * remove unused code * unexport handler
Adds the ability to supply arguments to the "just test" recipe in the contracts package. Developers frequently need to add arguments to test specific contracts and running "just test" as the unified testing command is better than flipping to "forge test".
There was one other spot where the batcher would log after tests exit, causing a panic.
* Update README.md * Update README.md * Update README.md
Fixes the stack-too-deep error in the PermissionedDisputeGame by updating the game to use a struct as the constructor parameter.
…ng (#13124) * add additional assertions to test to check for tx ordering * enhance test to handle tx confirmation ID ordering * increase size of 0th tx to expose race condition * change approach since the backend does not order txs by nonce * tidy * clarify * Update op-service/txmgr/queue_test.go Co-authored-by: Sebastian Stammler <[email protected]> --------- Co-authored-by: Sebastian Stammler <[email protected]>
* SendDepositTx: make applyL2Opts nil-able * move maxBlobs closer to used place * fix typo
When any of the setup transactions in `TestInterop_EmitLogs` fail to be mined, the test hangs until it times out. See [here](https://app.circleci.com/pipelines/github/ethereum-optimism/optimism/73118/workflows/b48debaa-55bc-4138-a419-a87c236cbc58/jobs/2994655/artifacts) for an example. This PR updates the SuperSystem API to take a context from the test itself to allow for timeouts.
* disable forge coverage in ci * disable forge coverage in ci * disable forge coverage in ci
Updates the Cannon libraries to be version agnostic instead of being pinned to 0.8.15. This is OK because we do not deploy libraries outside of contracts that have pinned contract versions.
Introduces a new common base framework for writing contracts check scripts in Go. Many of the check scripts basically do the exact same logic of somehow parsing either the interfaces or the artifact files. Goal of this small project is to make the process of writing new checks easier and more reliable. We demonstrate this framework in action by porting the test-names script to use this new framework.
Introduces mise for polyglot tool dependency management.
Golang map iteration order is random, so we need to sort first.
…d signing (#12325) * Initial implementation of integrating op-node with op-signer for remote signer configuration for block payload signing * op-service: remove the requirement for signer.address to be set when using op-service * op-service: add blockpayload_args to send to rpc opsigner_signBlockPayload * Implement mock rpc in gossip_test and apply review * Clean up tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )