Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Varlamore Wealthy Citizen Thieving #6157

Closed
wants to merge 5,721 commits into from
Closed

Add Varlamore Wealthy Citizen Thieving #6157

wants to merge 5,721 commits into from

Conversation

DayV-git
Copy link
Contributor

@DayV-git DayV-git commented Oct 28, 2024 •
edited
Loading

Description:

Added wealthy citizens to /steal. Requires corresponding OSJS PR . They are very afk (one click per 90s) compared to other thieving, so I have doubled trip length like for redwoods. The time to thieve is an average amount, based on a 100s cycle of 20s no-fail pickpocketing into ~80s downtime to match in game rates (55k per hour).

Changes:

  • Added Wealthy Citizens to /steal with double trip time as it is afk.
  • Added named quest requirement structure to stealables.
  • Corrected an issue where thieving would tell you you got a clue scroll, even if you didn't get a new one as you had one in bank.

Other checks:

  • I have tested all my changes thoroughly.

TastyPumPum and others added 30 commits August 21, 2024 13:13
@TastyPumPum
Fix Farmer role (oldschoolgg#6008)
e59dfb7
@nwjgit
Fix coffin creatables (oldschoolgg#5991)
10ed978
@Arodab
Fix elite clue drop rates for TOB (oldschoolgg#6010)
bb43e7c
@nwjgit
Armor pack fixes (oldschoolgg#5993)
44c0a40
@minimicronano
Add spirit flakes option to fish command (oldschoolgg#5948)
99fc046
@Arodab
Improve corp/scurrius boosts (oldschoolgg#6011)
247cd12
@nwjgit
Refactor combat achievement code (oldschoolgg#6004)
faee203
@gc
Use a spritesheet for images, update canvas (oldschoolgg#5965)
1ffdb0c
@gc
Remove unneeded spritesheet files
351c43d
@gc
Cleanup new bankimage code a bit
c97e99b
@nwjgit
Fix combat method bugs (oldschoolgg#6014)
0bf6429
@Lajnux
Add my notes activity (oldschoolgg#5564)
50c72bb
@nwjgit
Remove cannon message (oldschoolgg#6015)
1f9c657
@gc
Update OSJS/Spritesheet (oldschoolgg#6018)
fd5e5fb
@nwjgit
Fix minion kill (oldschoolgg#6026)
48f67aa
@dependabot
Bump micromatch from 4.0.4 to 4.0.8 (oldschoolgg#6019)
c0ce0ee 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@gc
Cleanup tools functions
0c067ea
@nwjgit
Add fancier boots (oldschoolgg#6025)
e207f2c
@gc
Rewrite minion kill command (oldschoolgg#6031)
984dd0d
@gc
Add bso spritesheet generation
b9a08a5
@gc
Fix spreadsheet action
9d05625
@gc
Add kcgains test
41077d7
@gc
Remove tripeffects test
d8ee166
@gc
Update monster table
869697f
@gc
Add bso spreadsheet
6eba9d1
@gc
Add yarn data script
b14d862
@gc
PVM Fixes
a38e191
@gc
UpdateBank changes/tests
7714bd4
@gc
PVM Fixes
2bd306f
@gc
Remove random variation on pvm trips
bf69759
@nwjgit nwjgit added Requires OSJS update Requires an OSJS PR to be merged first and removed Status: Waiting For Changes labels Nov 11, 2024
gc and others added 14 commits November 13, 2024 18:27
@gc
Add changelog, update some wiki pages
7d24b66
@gc
Update OSJS (crab droptable fix)
241c52c
@Arodab
Clue scrolls rebalancing (oldschoolgg#6111)
3af2561
@DayV-git
Merge branch 'oldschoolgg:master' into varlamore
7ec934d
@gc
Add test / fix degradeable items (oldschoolgg#6195)
d07bfb7
@gc
Clue stacking/juggling (oldschoolgg#6190)
2bb4d97
@nwjgit
Add amulet of torture similar items (oldschoolgg#6202)
5217977
@dependabot
Bump cross-spawn from 7.0.3 to 7.0.6 (oldschoolgg#6201)
9182219 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@themrrobert
Fix combat skill item requirements (oldschoolgg#6197)
e10f9aa
@dependabot
Bump cross-spawn from 7.0.3 to 7.0.6 in /docs (oldschoolgg#6203)
cb9fc2a 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@DayV-git
Add book of the dead buyable (oldschoolgg#6198)
3a653da
@DayV-git
Correct ammo and charge messages for /k (oldschoolgg#6187)
81a873c
@DayV-git
Remove max quantity from skotizo (and everywhere else) (oldschoolgg#6192
c90cd41 
)
@DayV-git
Merge branch 'oldschoolgg:master' into varlamore
984722f
@TastyPumPum TastyPumPum removed the Requires OSJS update Requires an OSJS PR to be merged first label Nov 21, 2024
@DayV-git DayV-git changed the title Add Valamore Wealthy Citizen Thieving Add Varlamore Wealthy Citizen Thieving Nov 21, 2024
@gc gc closed this Nov 23, 2024
@DayV-git DayV-git mentioned this pull request Nov 24, 2024
Merged
1 task
@DayV-git DayV-git deleted the varlamore branch November 28, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellipsis-dev ellipsis-dev[bot] ellipsis-dev[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.