Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Varlamore Wealthy Citizen Thieving #6215

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Conversation

DayV-git
Copy link
Contributor

Description:

Added wealthy citizens to /steal. Requires corresponding OSJS PR . They are very afk (one click per 90s) compared to other thieving, so I have doubled trip length like for redwoods. The time to thieve is an average amount, based on a 100s cycle of 20s no-fail pickpocketing into ~80s downtime to match in game rates (55k per hour).
#6157

Changes:

  • Added Wealthy Citizens to /steal with double trip time as it is afk.
  • Added named quest requirement structure to stealables.
  • Corrected an issue where thieving would tell you you got a clue scroll, even if you didn't get a new one as you had one in bank.

Other checks:

  • I have tested all my changes thoroughly.

src/mahoji/commands/steal.ts Outdated Show resolved Hide resolved
@@ -100,7 +110,7 @@ export const stealCommand: OSBMahojiCommand = {
return 'This NPC/Stall is missing variable respawnTime.';
}

const maxTripLength = calcMaxTripLength(user, 'Pickpocket');
const maxTripLength = (stealable.name === 'Wealthy Citizen' ? 2 : 1) * calcMaxTripLength(user, 'Pickpocket');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a 2x higher max trip length, are they really that afk?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that regular pickpocketing is very click intensive compared to regular woodcutting, I figured the comparison was valid. In game, this is considered a 'second monitor' activity, like redwoods or amethysts.

@DayV-git DayV-git requested a review from gc November 26, 2024 20:11
@gc gc merged commit 76d0c33 into oldschoolgg:master Nov 27, 2024
4 checks passed
@DayV-git DayV-git deleted the varlamore2 branch November 28, 2024 10:09
gc pushed a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants