Added ability to pass device token and device fingerprint #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at references this SDK.
Added deviceToken and deviceFingerprint parameters to fix E2E tests.
Added deviceToken and deviceFingerprint parameters to fix unit tests.
Passing nil for deviceFingerprint parameter.
Added accidentally removed curly brace.
|
@kochste77 , device token and device fingerprint were omitted on purpose in public API. You are not allowed to use these params in iOS applications Documentation links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to pass device token and device fingerprint from app that references this SDK.
Problem Analysis (Technical)
For "global sign-on policy - prompt for MFA once per device" support, there was no way to specify the device token in this SDK. While the web counterpart was working as expected, prompting users only on a new device/browser, iOS users had to complete MFA on every sign-in.
Solution (Technical)
Since this SDK already supports passing the device token to the Okta API, but there was no way to pass it from an app that references the SDK, I added a parameter that allows this. I also added the device fingerprint parameter even though we ended up not using it for our configuration (I believe the fingerprint affects Behavior Detection).
I am particularly interested in getting feedback from Okta here. I have maintained a forked repo to implement this missing piece for us. During our implementation phase, we reached out to our implementation specialist who recommended that we add this "feature" ourselves.
The reason I am posting this now is that we are experiencing very isolated issues with certain iOS users. A ticket was opened with Okta Support (case#00740227), but because we are unable to reproduce the issue on one of our devices, I decided to reach out via this PR to see if anybody might have an idea whether this "feature" is not fully supported on iOS, and was left out so far for that exact reason.
Affected Components
OktaAuthSdk.authenticate()
OktaAuthStatusUnauthenticated.authenticate()
Steps to reproduce:
N/A - missing "feature"
Actual result:
N/A - missing "feature"
Expected result:
N/A - missing "feature"
Tests