-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add Remember Device support #145
base: master
Are you sure you want to change the base?
WIP: Add Remember Device support #145
Conversation
@IldarAbdullin-okta I've just looked at #120. You said that https://developer.okta.com/docs/reference/api/authn/#device-token-best-practices BTW, fingerprint is not considering safe according to documentation. |
There are many contradictions in the documentation. My concern is based on the following statement:
Auth SDK doesn't use SSWS API token, so is considered as untrusted client and therefore can't use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but can you add some documentation somewhere to capture this? Thanks
@@ -150,6 +150,7 @@ open class OktaFactor { | |||
|
|||
public func verify(passCode: String?, | |||
answerToSecurityQuestion: String?, | |||
rememberDevice: Bool? = nil, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for assigning a default; it's nice that this won't result in a breaking API change.
@oleggnidets-okta What is the status of this pull request? Are we planning on still allowing |
Important: The Backend takes into account only
deviceToken
. If it exists then the backend perceivesrememberDevice
astrue
all the time. In other words,rememberDevice=false
is being ignored on backend side.Problem Analysis (Technical)
The library does not expose
rememberDevice
anddeviceToken
parameters.The feature was requested by the reporter in oidc-ios repo.
Solution (Technical)
Make
rememberDevice
anddeviceToken
available for developers.Tests
Added parameters in tests.
I didn't add the integration tests which assure that MFA is not asked one more time and device is remembered. Because it involves additional Policy rules. Also, I don't know which org is used because global variables are hidden in Travis settings.
If you see it's something required I can work on that more.