Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby 3 support #1

Closed
wants to merge 28 commits into from
Closed

Ruby 3 support #1

wants to merge 28 commits into from

Commits on Jan 17, 2024

  1. Refs #36846 - change descriptionFormat to snake case (Katello#10846)

    @jeremylenz
    jeremylenz authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    dfe70e8 View commit details
    Browse the repository at this point in the history

  2. Refs #35713 - correctly call methods with kwargs (Katello#10845)

    @jeremylenz
    jeremylenz authored Jan 17, 2024
    Configuration menu
    Copy the full SHA
    3ac7cdd View commit details
    Browse the repository at this point in the history

  3. Fixes #37028 - Set up sp-reference for content source

    @adamruzicka @chris1984
    adamruzicka authored and chris1984 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    57ab3c9 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Fixes #36994 - remove spaces from Ansible template (Katello#10849)

    @jeremylenz
    jeremylenz authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    e2cb74f View commit details
    Browse the repository at this point in the history

  2. Fixes #35974 - Extra index to check for installed package id (Katello… 

    …#10842)
    @parthaa
    parthaa authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    8591b4c View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Fixes #37005 - Allow to set the the default name of template change c… 

    …ontent source (Katello#10816)
    @Et7f3
    Et7f3 authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    8b17663 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Fixes #36946 - cache if tracer/host_tools is installed (Katello#10811)

    @sbernhard
    sbernhard authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    ced0ed0 View commit details
    Browse the repository at this point in the history

  2. Fixes #37080 - content counts index goes over max size

    @ianballou
    ianballou committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    acbe320 View commit details
    Browse the repository at this point in the history

  3. Fixes #37058 - Optimize query to identify orphaned content units

    @jpasqualetto @chris1984
    jpasqualetto authored and chris1984 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    799b4c0 View commit details
    Browse the repository at this point in the history

  4. use NodeJS 14 and Ruby 2.7 in React tests

    @evgeni @chris1984
    evgeni authored and chris1984 committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    f281fc5 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Fixes #37051 - Add job templates for Ansible 'by search query' (Katel… 

    …lo#10850)
    @jeremylenz
    jeremylenz authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    4f236c7 View commit details
    Browse the repository at this point in the history

  2. Refs #36846 - use descriptionFormat for updatePackages (Katello#10858)

    @jeremylenz
    jeremylenz authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    7e7d6d3 View commit details
    Browse the repository at this point in the history

  3. Fixes #37074 - drop users.disabled field 

    it exists in Foreman since 2.2 and makes DB migrations fail when
installing Katello ontop of Foreman

Fixes: c4b6d2c or 40ebede
    @evgeni @ehelms
    evgeni authored and ehelms committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    9915be7 View commit details
    Browse the repository at this point in the history

  4. Fixes #36998 - declare development dependency on theforeman-rubocop 

    `~> 0.0.6` was picked to match what's currently in Foreman core and thus
what gets used today when Rubocop is run by CI
    @evgeni @jeremylenz
    evgeni authored and jeremylenz committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    2e084c9 View commit details
    Browse the repository at this point in the history

  5. Refs #36998 - Fix Rails/Pick and Rails/IndexWith cops 

    These did not show up when running Rubocop from the Foreman checkout,
but do when executed directly from a Katello checkout.
    @evgeni @jeremylenz
    evgeni authored and jeremylenz committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    7f99691 View commit details
    Browse the repository at this point in the history

  6. Refs #36998 - disable Rails/ContentTag cop 

    The cop is buggy before rubocop-rails 2.12.0 [1][2], but to get that
we'd need a newer theforeman-rubocop, which generates more offenses than
I am willing to fix today. Disable the cop like it was disabled in
foreman_ansible too [3].

[1] rubocop/rubocop-rails#260
[2] rubocop/rubocop-rails#526
[3] theforeman/foreman_ansible#357
    @evgeni @jeremylenz
    evgeni authored and jeremylenz committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    98c9fee View commit details
    Browse the repository at this point in the history

  7. Fixes #37075 - make RemoveKatelloFromNotificationName a noop

    @evgeni @ehelms
    evgeni authored and ehelms committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    98a9b4d View commit details
    Browse the repository at this point in the history

  8. Fixes #37073 - only rename Katello settings if category column exists

    @evgeni @ehelms
    evgeni authored and ehelms committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    3773276 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Fixes #37050 - restrict module copying to source repository

    @ianballou
    ianballou committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    edd5341 View commit details
    Browse the repository at this point in the history

  2. Fixes #37084 - Drop simplecov dependency (Katello#10837) 

    This is a test dependency, but marked as a development dependency. We
currently install all development dependencies while testing katello,
but don't do that for any other plugin. This is an effort to reduce the
development dependencies to pure development dependencies.
    @ekohl
    ekohl authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    2ab734f View commit details
    Browse the repository at this point in the history

  3. Fixes #37032 - Drop minitest-tags development dependency 

    minitest-tags allows developers to run a single test, but it hasn't been
updated since 2012.
    @ekohl @ianballou
    ekohl authored and ianballou committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    477009b View commit details
    Browse the repository at this point in the history

  4. Fixes #37094 - Drop uglifier development dependency 

    Fixes: d23f8df
    @evgeni @ianballou
    evgeni authored and ianballou committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    6af370d View commit details
    Browse the repository at this point in the history

  5. Fixes #37083 - Remove unused pulp_export_destination setting 

    Fixes: a1e0372 ("Fixes #32580 - remove most pulp2 actions in planning")
    @ekohl @ianballou
    ekohl authored and ianballou committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    08dbe77 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Fixes #37100 - Update VCR to 6.1+

    @evgeni @ianballou
    evgeni authored and ianballou committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    cc1b7cc View commit details
    Browse the repository at this point in the history

  2. Fixes #37095 - Use shared GitHub workflow to run tests

    @evgeni
    evgeni committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    e3bf6db View commit details
    Browse the repository at this point in the history

  3. Refs #37095 - move test dependencies into an own group 

    Also drop some unused dependencies
    @evgeni
    evgeni committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    d4c9455 View commit details
    Browse the repository at this point in the history

  4. Run CI on Ruby 3

    @ofedoren
    ofedoren committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    aef65aa View commit details
    Browse the repository at this point in the history

  5. Ruby 3 support

    @ofedoren
    ofedoren committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    c090281 View commit details
    Browse the repository at this point in the history