Ruby 3 support #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`~> 0.0.6` was picked to match what's currently in Foreman core and thus what gets used today when Rubocop is run by CI
These did not show up when running Rubocop from the Foreman checkout, but do when executed directly from a Katello checkout.
The cop is buggy before rubocop-rails 2.12.0 [1][2], but to get that we'd need a newer theforeman-rubocop, which generates more offenses than I am willing to fix today. Disable the cop like it was disabled in foreman_ansible too [3]. [1] rubocop/rubocop-rails#260 [2] rubocop/rubocop-rails#526 [3] theforeman/foreman_ansible#357
This is a test dependency, but marked as a development dependency. We currently install all development dependencies while testing katello, but don't do that for any other plugin. This is an effort to reduce the development dependencies to pure development dependencies.
minitest-tags allows developers to run a single test, but it hasn't been updated since 2012.
Fixes: a1e0372 ("Fixes #32580 - remove most pulp2 actions in planning")
Also drop some unused dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Considerations taken when implementing this change?
What are the testing steps for this pull request?