Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/node: Refer to Oasis Core 23.0.x series everywhere #603

Closed
wants to merge 1 commit into from
Closed

docs/node: Refer to Oasis Core 23.0.x series everywhere #603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions docs/node/mainnet/eden-upgrade.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,11 +189,11 @@ an updated ParaTime containing new trust roots is released and adopted.

:::

8. Replace the old version of Oasis Node with version [23.0.3].
8. Replace the old version of Oasis Node with version [23.0.x].

:::info

The Oasis Core 23.0.3 binary in our published releases is built only for Ubuntu
The Oasis Core 23.0.x binary in our published releases is built only for Ubuntu
22.04 (GLIBC>=2.32). You'll have to build it yourself if you're using prior
Ubuntu versions (or other distributions using older system libraries).

Expand All @@ -214,15 +214,15 @@ Ubuntu versions (or other distributions using older system libraries).
[systemd]: https://systemd.io/
[Supervisor]: http://supervisord.org/
[Wipe state]: ../run-your-node/maintenance/wiping-node-state.md#state-wipe-and-keep-node-identity
[23.0.3]: https://github.com/oasisprotocol/oasis-core/releases/tag/v23.0.3
[23.0.x]: https://github.com/oasisprotocol/oasis-core/releases/tag/v23.0.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link needs to point to an actual release, can use the latest one, currently 23.0.4.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, @amela. Let's avoid writing 23.0.x and just replace 23.0.3 with 23.0.4 (and 23.0.5, if we make another release before the upgrade) except in my next comment below.

[rosetta-gw-2.6.0]:
https://github.com/oasisprotocol/oasis-rosetta-gateway/releases/tag/v2.6.0

### Configuration Changes

:::info

To see the full extent of the changes examine the [Change Log] of the 23.0.3
To see the full extent of the changes examine the [Change Log] of the 23.0.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, we probably want audience to read about changes that the new major version of Oasis Core brought and not the specific patch version, right?

Suggested change
To see the full extent of the changes examine the [Change Log] of the 23.0.x
To see the full extent of the changes examine the [Change Log] of the 23.0

release.

:::
Expand Down Expand Up @@ -276,13 +276,13 @@ network, while the other is used to bootstrap the Oasis P2P network.
:::

[Change Log]:
https://github.com/oasisprotocol/oasis-core/blob/v23.0.3/CHANGELOG.md
https://github.com/oasisprotocol/oasis-core/blob/v23.0.x/CHANGELOG.md

### Data Directory Changes

The subdirectory (located inside the node's data directory) used to store
consensus-related data, previously called `tendermint` (after the consensus
layer protocol backend) has been renamed to `consensus` in Oasis Core 23.0.3. If
layer protocol backend) has been renamed to `consensus` in Oasis Core 23.0.x. If
any of your scripts rely on specific directory names, please make sure to update
them to reflect the changed sdirectory name.

Expand Down
Loading