Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/node: Refer to Oasis Core 23.0.x series everywhere #603

Closed
wants to merge 1 commit into from

Conversation

amela
Copy link
Member

@amela amela commented Nov 9, 2023

Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for trusting-archimedes-14c863 ready!

Name Link
🔨 Latest commit 938e2b3
🔍 Latest deploy log https://app.netlify.com/sites/trusting-archimedes-14c863/deploys/654ca3003b19ea00077836dd
😎 Deploy Preview https://deploy-preview-603--trusting-archimedes-14c863.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amela amela requested a review from kostko November 9, 2023 09:13
@amela amela force-pushed the amela/eden-core-version-fix branch from 3ddb396 to 938e2b3 Compare November 9, 2023 09:14
@amela amela requested review from tjanez and matevz November 13, 2023 09:06
@@ -214,15 +214,15 @@ Ubuntu versions (or other distributions using older system libraries).
[systemd]: https://systemd.io/
[Supervisor]: http://supervisord.org/
[Wipe state]: ../run-your-node/maintenance/wiping-node-state.md#state-wipe-and-keep-node-identity
[23.0.3]: https://github.com/oasisprotocol/oasis-core/releases/tag/v23.0.3
[23.0.x]: https://github.com/oasisprotocol/oasis-core/releases/tag/v23.0.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link needs to point to an actual release, can use the latest one, currently 23.0.4.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, @amela. Let's avoid writing 23.0.x and just replace 23.0.3 with 23.0.4 (and 23.0.5, if we make another release before the upgrade) except in my next comment below.

@@ -214,15 +214,15 @@ Ubuntu versions (or other distributions using older system libraries).
[systemd]: https://systemd.io/
[Supervisor]: http://supervisord.org/
[Wipe state]: ../run-your-node/maintenance/wiping-node-state.md#state-wipe-and-keep-node-identity
[23.0.3]: https://github.com/oasisprotocol/oasis-core/releases/tag/v23.0.3
[23.0.x]: https://github.com/oasisprotocol/oasis-core/releases/tag/v23.0.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, @amela. Let's avoid writing 23.0.x and just replace 23.0.3 with 23.0.4 (and 23.0.5, if we make another release before the upgrade) except in my next comment below.

[rosetta-gw-2.6.0]:
https://github.com/oasisprotocol/oasis-rosetta-gateway/releases/tag/v2.6.0

### Configuration Changes

:::info

To see the full extent of the changes examine the [Change Log] of the 23.0.3
To see the full extent of the changes examine the [Change Log] of the 23.0.x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, we probably want audience to read about changes that the new major version of Oasis Core brought and not the specific patch version, right?

Suggested change
To see the full extent of the changes examine the [Change Log] of the 23.0.x
To see the full extent of the changes examine the [Change Log] of the 23.0

@amela amela closed this Nov 14, 2023
@matevz
Copy link
Member

matevz commented Nov 14, 2023

Superseeded by #611.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants