-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/node: Refer to Oasis Core 23.0.x series everywhere #603
Conversation
✅ Deploy Preview for trusting-archimedes-14c863 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3ddb396
to
938e2b3
Compare
@@ -214,15 +214,15 @@ Ubuntu versions (or other distributions using older system libraries). | |||
[systemd]: https://systemd.io/ | |||
[Supervisor]: http://supervisord.org/ | |||
[Wipe state]: ../run-your-node/maintenance/wiping-node-state.md#state-wipe-and-keep-node-identity | |||
[23.0.3]: https://github.com/oasisprotocol/oasis-core/releases/tag/v23.0.3 | |||
[23.0.x]: https://github.com/oasisprotocol/oasis-core/releases/tag/v23.0.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link needs to point to an actual release, can use the latest one, currently 23.0.4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, @amela. Let's avoid writing 23.0.x and just replace 23.0.3 with 23.0.4 (and 23.0.5, if we make another release before the upgrade) except in my next comment below.
@@ -214,15 +214,15 @@ Ubuntu versions (or other distributions using older system libraries). | |||
[systemd]: https://systemd.io/ | |||
[Supervisor]: http://supervisord.org/ | |||
[Wipe state]: ../run-your-node/maintenance/wiping-node-state.md#state-wipe-and-keep-node-identity | |||
[23.0.3]: https://github.com/oasisprotocol/oasis-core/releases/tag/v23.0.3 | |||
[23.0.x]: https://github.com/oasisprotocol/oasis-core/releases/tag/v23.0.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, @amela. Let's avoid writing 23.0.x and just replace 23.0.3 with 23.0.4 (and 23.0.5, if we make another release before the upgrade) except in my next comment below.
[rosetta-gw-2.6.0]: | ||
https://github.com/oasisprotocol/oasis-rosetta-gateway/releases/tag/v2.6.0 | ||
|
||
### Configuration Changes | ||
|
||
:::info | ||
|
||
To see the full extent of the changes examine the [Change Log] of the 23.0.3 | ||
To see the full extent of the changes examine the [Change Log] of the 23.0.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, we probably want audience to read about changes that the new major version of Oasis Core brought and not the specific patch version, right?
To see the full extent of the changes examine the [Change Log] of the 23.0.x | |
To see the full extent of the changes examine the [Change Log] of the 23.0 |
Superseeded by #611. |
Preview: https://deploy-preview-603--trusting-archimedes-14c863.netlify.app/node/mainnet/eden-upgrade