sapphire: initial notes on authenticated calls & contract authentication #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for trusting-archimedes-14c863 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aefhm
reviewed
Jul 31, 2023
aefhm
reviewed
Jul 31, 2023
matevz
requested changes
Aug 2, 2023
There was a problem hiding this comment.
First pass.
Also, can you wrap the lines to 80 characters, so it's easier to read the source code and review it on github.
And also we should mention this chapter in https://deploy-preview-476--trusting-archimedes-14c863.netlify.app/dapp/sapphire/guide#transactions--calls section where we already talk about signed/unsigned calls and MetaMask popups.
matevz
requested changes
Aug 14, 2023
| another contract in a way which could reveal sensitive information, the calling | ||
| contract must implement access control or authentication. | ||
|
|
||
| By default all `eth_call` queries used to invoke contract functions have the |
There was a problem hiding this comment.
By default? I don't think you can easily change this behavior in Sapphire so I would remove "By default".
Comment on lines
+85
to
+86
| These parameters are visible in the EIP-712 popup signed by the user. Queries | ||
| with the same parameters will use the same leash. |
There was a problem hiding this comment.
Suggested change
| These parameters are visible in the EIP-712 popup signed by the user. Queries | |
| with the same parameters will use the same leash. | |
| These parameters are visible in the [EIP-712][eip-712] popup signed by the user. **Queries | |
| with the same parameters will use the same leash.** |
Perhaps this would be a good place to have a screenshot of Metamask showing some EIP-712 content?
Co-authored-by: Matevž Jekovec <[email protected]>
Co-authored-by: Matevž Jekovec <[email protected]>
Co-authored-by: Matevž Jekovec <[email protected]>
Co-authored-by: Matevž Jekovec <[email protected]>
Co-authored-by: Matevž Jekovec <[email protected]>
Co-authored-by: Matevž Jekovec <[email protected]>
Co-authored-by: Matevž Jekovec <[email protected]>
Co-authored-by: Matevž Jekovec <[email protected]>
Co-authored-by: Matevž Jekovec <[email protected]>
Co-authored-by: Matevž Jekovec <[email protected]>
Co-authored-by: Matevž Jekovec <[email protected]>
Co-authored-by: Matevž Jekovec <[email protected]>
Co-authored-by: Matevž Jekovec <[email protected]>
aefhm
approved these changes
Aug 29, 2023
matevz
approved these changes
Sep 5, 2023
|
|
||
| Behind the scenes the signed queries use a "leash" to specify validity conditions | ||
| so the query can only be performed within a block and account `nonce` range. | ||
| These parameters are visible in the EIP-712 popup signed by the user. Queries |
There was a problem hiding this comment.
If the query is cached, then no user interaction is required? Where does EIP-712 popup then come from?
|
|
||
| Behind the scenes the signed queries use a "leash" to specify validity conditions | ||
| so the query can only be performed within a block and account `nonce` range. | ||
| These parameters are visible in the EIP-712 popup signed by the user. Queries |
There was a problem hiding this comment.
Suggested change
| These parameters are visible in the EIP-712 popup signed by the user. Queries | |
| These parameters are visible in the [EIP-712][eip-712] popup signed by the user. Queries |
Co-authored-by: Matevž Jekovec <[email protected]>
Co-authored-by: Xi Zhang <[email protected]>
Co-authored-by: Xi Zhang <[email protected]>
Co-authored-by: Matevž Jekovec <[email protected]>
Co-authored-by: Matevž Jekovec <[email protected]>
Co-authored-by: Matevž Jekovec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers patterns for verifying caller identity for view calls.
Preview: https://deploy-preview-476--trusting-archimedes-14c863.netlify.app/dapp/sapphire/authentication