Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sapphire/Precompiles: add notes about <=0.5.2 eth_call RNG behavior + detail on how VRF works #481

Merged
merged 4 commits into from
Aug 9, 2023
Merged

Sapphire/Precompiles: add notes about <=0.5.2 eth_call RNG behavior + detail on how VRF works #481

merged 4 commits into from
Aug 9, 2023

Conversation

CedarMist
Copy link
Member

image

@CedarMist CedarMist requested a review from kostko July 31, 2023 11:34
@netlify
Copy link

netlify bot commented Jul 31, 2023 •
edited
Loading

✅ Deploy Preview for trusting-archimedes-14c863 ready!

Name Link
🔨 Latest commit c019e67
🔍 Latest deploy log https://app.netlify.com/sites/trusting-archimedes-14c863/deploys/64d3882f4c48a900089a8008
😎 Deploy Preview https://deploy-preview-481--trusting-archimedes-14c863.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kostko
kostko reviewed Jul 31, 2023
View reviewed changes
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewing the part that is not based on #476, I suggest you remove the duplicate commits from this PR.

docs/dapp/sapphire/precompiles.md Outdated Show resolved Hide resolved
docs/dapp/sapphire/precompiles.md Outdated Show resolved Hide resolved
aefhm
aefhm reviewed Jul 31, 2023
View reviewed changes
docs/dapp/sapphire/precompiles.md
```
:::

The mode (e.g. simulation or 'view call' vs transaction execution) is fed to TupleHash (among other
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nice to have) I wish we had a diagram/design doc visual for this.

@CedarMist CedarMist force-pushed the CedarMist/rng-notes branch from a2a504d to 4f24466 Compare July 31, 2023 15:20
@CedarMist
sapphire/precompiles: added NIST link, changed warning to 'prior to 0…
aa9744a 
….6.0' and added 'Implementation Details' to RNG section
@CedarMist
Copy link
Member Author

Only reviewing the part that is not based on #476, I suggest you remove the duplicate commits from this PR.

This has been rebased onto main. In future I will not use a fork, but a branch of this repo for changes.

@CedarMist CedarMist self-assigned this Aug 2, 2023
@CedarMist CedarMist requested a review from kostko August 8, 2023 12:01
@CedarMist CedarMist merged commit c069468 into oasisprotocol:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aefhm aefhm aefhm left review comments

@kostko kostko kostko approved these changes

Assignees

@CedarMist CedarMist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CedarMist @kostko @aefhm