Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove out of date instructions from contributing.md #1774

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Remove out of date instructions from contributing.md #1774

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b78546
jq and bc are already installed in the container
dagardner-nv Jun 28, 2024
e90b971
Remove section about running pip install
dagardner-nv Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions docs/source/developer_guide/contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,26 +144,19 @@ This workflow utilizes a Docker container to set up most dependencies ensuring a
Then once the container is started you will need to install some extra packages to enable launching Docker containers:
```bash
./external/utilities/docker/install_docker.sh

# Install utils for checking output
apt install -y jq bc
```

3. Compile Morpheus
```bash
./scripts/compile.sh
```
This script will run both CMake Configure with default options and CMake build.
4. Install Morpheus
```bash
pip install -e /workspace
```
Once Morpheus has been built, it can be installed into the current virtual environment.
5. [Run Morpheus](../getting_started.md#running-morpheus)
This script will run CMake Configure with default options, the CMake build and install Morpheus into the environment.

4. [Run Morpheus](../getting_started.md#running-morpheus)
```bash
morpheus run pipeline-nlp ...
```
At this point, Morpheus can be fully used. Any changes to Python code will not require a rebuild. Changes to C++ code will require calling `./scripts/compile.sh`. Installing Morpheus is only required once per virtual environment.
At this point, Morpheus can be fully used. Any changes to Python code will not require a rebuild. Changes to C++ code will require calling `./scripts/compile.sh`.

### Build in a Conda Environment

Expand Down
Loading