Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove out of date instructions from contributing.md #1774

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jun 28, 2024

Description

  • jq and bc are installed in the container by default
  • pip intall is no longer needed as this is now executed by cmake

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner June 28, 2024 17:31
@dagardner-nv dagardner-nv self-assigned this Jun 28, 2024
@dagardner-nv dagardner-nv added non-breaking Non-breaking change doc Improvements or additions to documentation labels Jun 28, 2024
@dagardner-nv dagardner-nv changed the title Remove instructions to install jq and bc from contributing.md as these are already installed in the container Remove out of date instructions from contributing.md Jun 28, 2024
@dagardner-nv dagardner-nv requested a review from mdemoret-nv June 28, 2024 17:40
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 59109fe into nv-morpheus:branch-24.06 Jun 28, 2024
15 checks passed
@dagardner-nv dagardner-nv deleted the david-remove-jq-bc-contrib-doc branch June 28, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants