check mode for delete operations #422
Conversation
| @@ -96,8 +96,15 @@ def delete_image(module, result): | |||
| image = Image(module, delete_image=True) | |||
| fname = module.params["filename"] | |||
| itype = module.params["installer_type"] | |||
|
|
|||
| if module.check_mode: | |||
| result["file_name"] = fname | |||
There was a problem hiding this comment.
why we need this ? We are already have file name in response messge.
There was a problem hiding this comment.
Let it be consistent with upload_image()
There was a problem hiding this comment.
And it should be 'image_name' if required. Add in upload_image() as well.
plugins/modules/ntnx_acps.py
Outdated
| @@ -466,6 +466,11 @@ def delete_acp(module, result): | |||
| result["error"] = "Missing parameter acp_uuid in playbook" | |||
| module.fail_json(msg="Failed deleting acp", **result) | |||
|
|
|||
| if module.check_mode: | |||
| result["acp_uuid"] = acp_uuid | |||
| result["response"] = "Acp with uuid:{0} will be deleted.".format(acp_uuid) | |||
There was a problem hiding this comment.
Update all reviews
| result["response"] = "Acp with uuid:{0} will be deleted.".format(acp_uuid) | |
| result["msg"] = "Acp with uuid:{0} will be deleted.".format(acp_uuid) |
|
@alaa-bish @Gevorg-Khachatryan-97 Please add tests to cover added code changes. |
| result["imaged_cluster_uuid"] = cluster_uuid | ||
| result["msg"] = "Cluster with uuid:{0} will be deleted.".format(cluster_uuid) | ||
| return | ||
|
|
There was a problem hiding this comment.
@bhati-pradeep could not find any test for deletion
There was a problem hiding this comment.
@bhati-pradeep there is no any test for delete stretched vlan
There was a problem hiding this comment.
@bhati-pradeep there is no delete tests
| @@ -1499,6 +1499,12 @@ def delete_db_servers(module, result, database_info): | |||
| spec = db_servers.get_default_delete_spec( | |||
| delete=module.params.get("delete_db_server_vms", False) | |||
| ) | |||
|
|
|||
| if module.check_mode: | |||
There was a problem hiding this comment.
Why do we have check_sum for delete_db_servers, as we have it for delete_instance
No description provided.