Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Imprv] add functionality <functionality_name> to module <module_name> #334

Open
guntis-liepins opened this issue Feb 27, 2023 · 1 comment · May be fixed by #422
Open

[Imprv] add functionality <functionality_name> to module <module_name> #334

guntis-liepins opened this issue Feb 27, 2023 · 1 comment · May be fixed by #422
Assignees
Labels
1.9.3_triage Bug fixes & Improvements enhancement New feature or request triage Tickets for triage

Comments

@guntis-liepins
Copy link

Describe the request
Enable dry run mode with --check

Current behaviour
Currently it seems to ignore this flag and just proceeds with operations like deleting vms regardless of value of this flag.

Expected behaviour
With --check flag module must follow ansible check mode default behaviour:
https://docs.ansible.com/archive/ansible/2.3/playbooks_checkmode.html
i.e. show that it will create or delete objects instead of creating them.

Rationale: In production enviroments most admins want to check playbook first to make sure variables, host groups, etc. is set correctly and then proceed with operation. It is very dangerous to run multi machine complex playbooks without checking it prior production run.

@guntis-liepins guntis-liepins added the enhancement New feature or request label Feb 27, 2023
@bhati-pradeep bhati-pradeep added the triage Tickets for triage label Mar 3, 2023
@bhati-pradeep bhati-pradeep added the 1.9.1 Bug fixes & Improvements label Sep 25, 2023
@Gevorg-Khachatryan-97 Gevorg-Khachatryan-97 linked a pull request Oct 18, 2023 that will close this issue
@bhati-pradeep bhati-pradeep added 1.9.3_triage Bug fixes & Improvements and removed 1.9.1 Bug fixes & Improvements labels Oct 30, 2023
@bhati-pradeep
Copy link
Collaborator

bhati-pradeep commented Oct 30, 2023

Moving it from 1.9.1 -> 1.9.3 as it would need test additions in all integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.9.3_triage Bug fixes & Improvements enhancement New feature or request triage Tickets for triage
Projects
Development

Successfully merging a pull request may close this issue.

6 participants